2010365 - Firefox 148b1 for Android address bar autocorrects input

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Yi Hao]

User Agent: Mozilla/5.0 (Android 16; Mobile; rv:148.0) Gecko/148.0 Firefox/148.0

Steps to reproduce:

Type in an address manually using a keyboard with auto correct turned on:
bleepingcomputer.com

Suspect text field missing:
android:inputType="textUri"

Actual results:

The keyboard treat the address bar as a generic text field and auto correct it to:
bleeping computer.<space>

Expected results:

No auto correct like in v147

Comment 1

[Rhodwell Malicdem [:RJ]]

The same issue is also brought up recently in Reddit.

Comment 2

[Moyin [:moyin]]

Please double check if the old toolbar has this issue before fixing it

Comment 3

[Rhodwell Malicdem [:RJ]]

The issue is reproducible when using Gboard with the composable toolbar, but does not occur with the legacy toolbar. It currently affects the latest release (147.0.1).

Comment 4

[Rhodwell Malicdem [:RJ]]

From further testing, the issue seems to reproduce only in normal mode (not in private/incognito mode). A quick review of the code suggests this may be intentional.

Petru, could you please verify if this is the expected behavior?

Comment 5

[Petru-Mugurel Lingurar [:petru]]

(In reply to Rhodwell Malicdem [:RJ] from comment #4)

From further testing, the issue seems to reproduce only in normal mode (not in private/incognito mode). A quick review of the code suggests this may be intentional.

Petru, could you please verify if this is the expected behavior?

Yes, this was intentional to help with inputting search terms but tested with older versions of Firefox and with Chrome and they don't allow this.
So if it's causing issues we can avoid this.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2010365 - Disable text autocorrect in the composable toolbar r=#android-reviewers

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1994013

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c34ca969ce03
https://hg.mozilla.org/integration/autoland/rev/df48ad898e6e
Disable text autocorrect in the composable toolbar r=android-reviewers,moyin

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/df48ad898e6e

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox148 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Typed URL might be autocorrected leading to user frustration.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=2010365#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Simple flag change to disable autocorrect.
• String changes made/needed: --
• Is Android affected?: no

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2010365 - Disable text autocorrect in the composable toolbar

Original Revision: https://phabricator.services.mozilla.com/D280713

Comment 13

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: Typed URL might be autocorrected leading to user frustration.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=2010365#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Simple flag change to disable autocorrect.
• String changes made/needed: --
• Is Android affected?: no

Comment 14

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2010365 - Disable text autocorrect in the composable toolbar

Original Revision: https://phabricator.services.mozilla.com/D280713

Comment 15

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Nightly 149.0a1 from 1/29 using a Google Pixel (Android 10), and a Huawei Pura 70 (Android 12).

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/d2bc23882cca
https://hg.mozilla.org/releases/mozilla-beta/rev/7421035c162a

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/cd300d542434
https://hg.mozilla.org/releases/mozilla-release/rev/7ea124c73a9d

Comment 18

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Beta 148.0b9 using a Google Pixel (Android 10), and a Motorola Moto G30 (Android 12).

Comment 19

[Lorand Janos]

Verified as fixed on the latest Firefox for Android RC 147.0.3 using a Vivo Y22S (Android 13), and a Samsung Galaxy S25 Ultra (Android 16).