2011462 - Investigate assertions in crashtests after bug 1994346 with layout.abspos.fragmentainer-aware-positioning.enabled=true

Status: RESOLVED FIXED

(Core :: Layout: Positioned, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Below is a list of crashtests that have trigger addition assertions after applying my WIP from bug 1994346 with the pref layout.abspos.fragmentainer-aware-positioning.enabled set to true:

REFTEST TEST-UNEXPECTED-FAIL | layout/generic/crashtests/509749-1.html | assertion count 2 is more than expected 0 assertions
REFTEST TEST-UNEXPECTED-FAIL | layout/generic/crashtests/580504-1.xhtml | assertion count 3 is more than expected 0 assertions
REFTEST TEST-UNEXPECTED-FAIL | layout/generic/crashtests/1764205.html | assertion count 14 is more than expected 4 assertions

The assertion is

###!!! ASSERTION: Shouldn't be incomplete if availableBSize is UNCONSTRAINED.: 'aReflowInput.AvailableBSize() != NS_UNCONSTRAINEDSIZE',

1764205.html triggers following additional assertions (added in bug 1994346).

###!!! ASSERTION: UnfragmentedPositionProperty should only be set on first-in-flow!

Bug 1994346 added a measuring reflow in multicol, so it looks like in an incremental reflow, some frames fails to become fully-complete in the measuring reflow, triggering the first assertion. That results in some continuations left in the abscb, triggering the second assertion.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: Bug 2011462 - Increase the assertion counts for crashtest 1764205.html. r?#layout

1764205.html already triggers

###!!! ASSERTION: Shouldn't be incomplete if availableBSize is UNCONSTRAINED.:
'aReflowInput.AvailableBSize() != NS_UNCONSTRAINEDSIZE',

With bug 1994346 and
layout.abspos.fragmentainer-aware-positioning.enabled=true, it triggers
additional

###!!! ASSERTION: UnfragmentedPositionProperty should only be set on
first-in-flow!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cbe831a1185b
https://hg.mozilla.org/integration/autoland/rev/2a9877be9c10
Increase the assertion counts for crashtest 1764205.html. r=layout-reviewers,dholbert

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2a9877be9c10