Closed Bug 2012442 Opened 7 months ago Closed 5 months ago

Closing Firefox logs out the user from Firefox Enterprise

Categories

(Enterprise Products :: Firefox, enhancement)

Desktop
All
enhancement

Tracking

(Not tracked)

VERIFIED FIXED
Foxfooding

People

(Reporter: RT, Assigned: jporter)

References

Details

(Whiteboard: [size=2])

User Story

Acceptance criteria:
- Closing Firefox through the different entry points (Close Firefox Window, File/Quit, Hamburger menu/Quit) terminates the user session
- On next Firefox Enterprise launch the user must authenticate though SSO

Attachments

(12 files, 1 obsolete file)

144.85 KB, image/png
Details
165.28 KB, image/png
Details
61.72 KB, image/png
Details
54 bytes, text/x-github-pull-request
Details | Review
41.98 KB, image/png
Details
93.08 KB, image/png
Details
54 bytes, text/x-github-pull-request
Details | Review
54 bytes, text/x-github-pull-request
Details | Review
54 bytes, text/x-github-pull-request
Details | Review
54 bytes, text/x-github-pull-request
Details | Review
36.09 KB, image/png
Details
116.31 KB, image/png
Details
No description provided.
User Story: (updated)
No longer depends on: 2012440
Blocks: 2012452
No longer blocks: 2012452

Hey Matt, can you please help with the UX for the close tab confirmation message - we discussed that we could leverage this UI to inform the user that it will be signed-out when they close Firefox.

Flags: needinfo?(mcroud)

Please find attached the modal to display when a user chooses to directly close Firefox Enterprise.
This uses the standard Acorn Dialog component, exactly matching the existing "Close x tabs" dialog.

The Figma file is here: https://www.figma.com/design/xYH6L8QrDz0Q16XFvdo7We/%F0%9F%A6%8A-Client-Design?node-id=1614-2072&t=p6JOJqAI2bmMZM8V-1

Flags: needinfo?(mcroud)
Attached image sign out.png

As per recent discussions, the UX has been updated to combine both the "multi-tab" and "sign out" warnings into a single dialog.

The attached image shows how the content changes based on the users saved preferences.

The Figma design is available here: https://www.figma.com/design/xYH6L8QrDz0Q16XFvdo7We/%F0%9F%A6%8A-Client-Design?node-id=1616-7974&t=9rJfpg4K3PEEHblX-1

Blocks: 1980741
Duplicate of this bug: 2010529
Priority: -- → P1
Severity: -- → S1
Whiteboard: [size=2]
Target Milestone: --- → Foxfooding
Assignee: nobody → lissyx+mozillians
Severity: S1 → S2
Priority: P1 → --
Assignee: lissyx+mozillians → joporter
Status: NEW → ASSIGNED
Attached image Current Signout prompt

What about the current Signout prompt? It's triggered when the user clicks the Signout button on the enterprise panel. Do we want to alter this prompt as well?

Flags: needinfo?(mcroud)

Good catch, thank you.
Yes, signing out through the enterprise panel triggers the same end result as closing the browser, the session ends, the user is returned to FELT, and any open tabs are lost. So it makes sense to align the messaging and use the same catch-all warning pattern.

Flags: needinfo?(mcroud)
Attached image macos-quit-prompt.png (obsolete) —

Janika raised another scenario for the combo dialog and signout process. On MacOS we have one more way of exiting: cmd+q. This provides a different interface and checkbox/pref. This path exits the process completely, the user is successfully logged out and prompted with FELT on next launch.

How should we handle this path? Display the same dialog box as-is, or adapt the current dialog and logic to include the additional checkbox and close tab button?

edit: this can exist on Windows too if browser.warnOnQuitShortcut is set. also updated the image below to include the "Close current tab" scenario

Flags: needinfo?(mcroud)
Attached image macos-quit-prompt.png
Attachment #9554391 - Attachment is obsolete: true
Blocks: 2024613
Attached image CMD + Q.png

Thank you for this! I see there are two versions as well, one for a single tab, the other for multiple tabs.

I believe CMD + Q is a long standing pattern to completely quite out of applications, and following the existing content patterns of saying "quit" over "close", I feel we should follow with expectations and have this completely quit the process including FELT.

Please find attached the new CMD+Q modals. The Figma artwork is here: https://www.figma.com/design/xYH6L8QrDz0Q16XFvdo7We/%F0%9F%A6%8A-Client-Design?node-id=2255-286&t=CJ0huJMZkxmhblvM-1

I did have to extend the width of the 3 button modal by a small amount to capture the button group, would this modal expand its width to accommodate longer button labels?

One last thing to mention, we are moving away from the term "Company" and moving towards "Organization", therefore can we please update the other Quit modals to say "To use Firefox Enterprise again, you’ll need to reauthenticate through your organization’s SSO provider."

Thank you very much!

Flags: needinfo?(mcroud)
Duplicate of this bug: 2005726

Authored by https://github.com/gcp
https://github.com/mozilla/enterprise-firefox/commit/5becc120b6338d340330d7c29eb365bc3debcc14
[enterprise-main] Bug 2012442 - Sign out session when Firefox exits normally (#674)

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED

Hello team,
What is the final UI for the feature in this tichet?
This is what I have an my Ubuntu when tryng to close the browser via the "x" button.
Thank you.

Flags: needinfo?(joporter)

That is the current UI for this feature, the expanded UI with the dual checkboxes will be addressed in 2024613.

Apologies, I think some of the conversation around this feature happened in this ticket before the UX was split into a separate bug.

Thank you!

Flags: needinfo?(joporter)
Attached image Sign out.png

So far in testing the 150.0  (20260419183446) smoke build on macOS Tahoe 26.3 I've checked:

  • Sign out from toolbar> Sign out, with one or multiple tabs
  • Sign out from dock icon while FxE window is open
  • Sign out from dock after closing window with X (session is not terminated)
  • Sign out modal showing when using Quit from the Activity Monitor to kill the process
  • Quit with CMD+ Q keys also shows the modal
  • Sign out from Enterprise when multiple windows are open

As posted in the previous QA comment, the modal heading changes from "Sign out of Firefox Enterprise?" to "Sign out and close X tabs?" when trying to close a a window that contains more than one tabs. This also applies to multiple windows (sign out modal shows the total number of tabs for all open windows).
Cancel and Sign out functionality apply as expected.

Tested the 150.0 (20260419183446) smoke build on Ubuntu 24
The modal is displayed for the following scenarios:

  • Sign out from toolbar/account menu> Sign out, with one or multiple tabs
  • Quit from dock icon while FxE window is open
  • Close window from the X button
  • Quit with ALT+F4 key combination
  • Quit Firefox Enterprise when multiple windows are open

The modal is not displayed for the following scenario:

  • Using the System Monitor to kill the process

Thank you.

(In reply to lburuian from comment #21)

Tested the 150.0 (20260419183446) smoke build on Ubuntu 24
The modal is displayed for the following scenarios:

  • Sign out from toolbar/account menu> Sign out, with one or multiple tabs
  • Quit from dock icon while FxE window is open
  • Close window from the X button
  • Quit with ALT+F4 key combination
  • Quit Firefox Enterprise when multiple windows are open

The modal is not displayed for the following scenario:

  • Using the System Monitor to kill the process

I checked and system monitors sends a hard kill, resulting in -15 exit code, that makes us:

I have checked on Windows 10 and 11 to confirm, using the same Enterprise 150.0 build (20260419183446).
The modal is only not shown when killing the process from the task manager.

(In reply to Peter Magyari (Desktop QA) from comment #23)

I have checked on Windows 10 and 11 to confirm, using the same Enterprise 150.0 build (20260419183446).
The modal is only not shown when killing the process from the task manager.

Likely for the same reason: we have no mean to intercept the killing process, so no way to show a modal dialog

Flags: qe-verify+

Setting this as Verified fixed based on the test results on Win 10 and 11, Ubtunu 24 and macOS Tahoe 26.3 on the enterprise-release 150.0 build (20260419183446).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 2035477
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: