2016551 - smartbar memory toggle should be shown when memories exist

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, enhancement)

Description

[Ed Lee :Mardak]

bug 2011323 added memory toggle with a disabled state but should be hidden if no memories or memories off https://www.figma.com/design/5KuePTGmOEUFyCHBHCsGim/AI-Mode-%E2%80%94%C2%A0MVP-Scope-Design?node-id=20194-484170

Comment 1

[Ed Lee :Mardak]

bug 2017428 updated the logic to check for either generation pref are enabled, but the desired behavior is still only show the toggle if there's memories

chidam suggested getAllMemories check if non-empty https://searchfox.org/firefox-main/rev/83d1a08db47b91a4d53341a799745caac9c38bde/browser/components/aiwindow/models/memories/MemoriesManager.sys.mjs#395

Comment 2

[Punam Dahiya [:pdahiya]]

Followup of fix in bug 2017428 that implemented

Both pref on - toggle show
Both pref off - toggle hide

Scope of this bug is to use MemoriesManager.getAllMemories() check to see non-empty and use logic to show/hide toggle based of memory existence as below
Both pref on - show
Both pref off and memory exist - show
Both pref off and memory doesn’t exist - hide

See discussion in thread here and here

Comment 3

[Chloe Zhou [:chloezhou]]

Attachment: Bug 2016551 - Show memories toggle when memories exist if both prefs are off and restore toggle state on tab switch. r=pdahiya

Previously the memories toggle in the AI Window smartbar was only visible when at least one of the generateFromConversation/generateFromHistory prefs was enabled. This meant users who disabled both prefs after accumulating memories could no longer see or use the toggle.

Now the toggle is shown whenever memories exist, regardless of pref state. The component observes memory-store-changed so the toggle hides immediately when the last memory is deleted from settings.

Tests cover sidebar and fullpage modes for all three visibility states: prefs off + memories exist (shown), all memories deleted (hidden), and prefs turned on (shown).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/86e9911f8079
https://hg.mozilla.org/integration/autoland/rev/131ea7241723
Show memories toggle when memories exist if both prefs are off and restore toggle state on tab switch. r=pdahiya,ai-frontend-reviewers

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/131ea7241723

Comment 6

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Beta 150.0b1 and our latest Nightly build, however there is a scenario where if we disable both preferences and we have a few memories saved the Toggle button is still displayed as ON, I have logged this issue for it Bug 2026595