2017764 - More performance improvements for TreeDataAdapter and AutoTreeView

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Geoff Lankow (:darktrojan)]

I've made more gains in the speed of TreeDataAdapter and AutoTreeView.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 2017764 - Cache a list of all visible rows in TreeDataAdapter. r=freaktechnik

If we squash the hierarchy down to a flat list and (importantly) remember that list until it
changes, finding rows and calculating things is much faster.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 2017764 - Create a fragment for AutoTreeView rows and only update what changes. r=freaktechnik

Every row in a tree view is going to have the same DOM, so we can create it once and clone it.
This is much faster than creating all of the elements every time a row needs updating. We do have
to take care that when we recycle rows we clear out the previous state.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/779cdace8b80
Cache a list of all visible rows in TreeDataAdapter. r=freaktechnik
https://hg.mozilla.org/comm-central/rev/cdede8e8d0b5
Create a fragment for AutoTreeView rows and only update what changes. r=freaktechnik

Comment 4

[Magnus Melin [:mkmelin]]

I'd assume the comm/mail/base/test/browser/widgets/browser_autoTreeView.js failures are from here.
https://treeherder.mozilla.org/jobs?repo=comm-central&selectedTaskRun=TVThxG1QTUeI_FCeMkHpHw.0

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 2017764 - Modify row cache when expanding or collapsing a row. r=freaktechnik

Instead of destroying the row cache and rebuilding it, we can just insert or remove the rows.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2e372ba07ab7
Modify row cache when expanding or collapsing a row. r=freaktechnik