2020354 - Two links to redesigned privacy & security settings are partially broken

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Malte Jürgens [:maltejur]]

Attachment: Screenshot_20260302_161537.png

To reproduce:

1. Open https://www.kephyr.com/popupkillertest/test/test1.html or any other site trying to open a popup without user interaction
2. In the notification at the top of the page, click on Preferences > Manage pop-up and third-party redirect settings...

Expected result: The Privacy & Security settings page (about:preferences#privacy) opens and scrolls to the "Block pop-ups and third-party redirects" checkbox
Actual result: The Privacy & Security settings page (about:preferences#privacy) opens, but stays at the top and doesn't scroll to the relevant preference

Comment 1

[Malte Jürgens [:maltejur]]

Attachment: Bug 2020354 - Fix missing subcategories for links in privacy & security settings r?#settings-reviewers-rotation

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1971428

Comment 3

[Malte Jürgens [:maltejur]]

Attachment: Screenshot_20260302_170918.png

Searching through the code for other occurrences of broken links to the privacy & security page, I only found one other, much less commonly used link to the site data settings which I'll just include in this bug: https://searchfox.org/firefox-main/rev/3c918058f580ec2cd39d80c9f77ccd06982c0029/browser/base/content/browser.js#1093.

Reproducing that one is a bit harder, as it just shows up when disk space is low and Firefox is using up a lot of space. The easiest way to trigger that is to just run browser_storagePressure_notification.js with a await new Promise(() => {}); added in line 118, which will show the notification in the attached screenshot with a (currently broken) link to the site data settings.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ea25aafc0268
https://hg.mozilla.org/integration/autoland/rev/87ca6b8480d2
Fix missing subcategories for links in privacy & security settings r=akulyk

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/87ca6b8480d2

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:maltejur, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox149 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: "Manage pop-up and third-party redirect settings" button in the blocked pop-up notification will be partially broken (it will lead to the settings page but not scroll down to the correct settings entry).
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: See Bug 2020354
• Risk associated with taking this patch: low
• Explanation of risk level: This patch is just adding two missing data-subcategory attributes to the Privacy & Security settings page, which has little to no breakage potential. Additionally, we are early in the cycle.
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Malte Jürgens [:maltejur]]

Attachment: Bug 2020354 - Fix missing subcategories for links in privacy & security settings

These were previously located in
browser/components/preferences/privacy.inc.xhtml and seem to have not been
migrated.

"privacy-sitedata" is still used here:
https://searchfox.org/firefox-main/rev/3c918058f580ec2cd39d80c9f77ccd06982c0029/browser/base/content/browser.js#1093

"privacy-permissions-block-popups" is still used here:
https://searchfox.org/firefox-main/rev/3c918058f580ec2cd39d80c9f77ccd06982c0029/browser/modules/PopupAndRedirectBlockerObserver.sys.mjs#389

From searching through the code, these should be all that are still missing for
the privacy & security settings page.

Original Revision: https://phabricator.services.mozilla.com/D285508

Comment 9

[Donal Meehan [:dmeehan]]

:maltejur, to add to comment 6, if you also add a release uplift request we could included in the planned Fx148 dot release.

Comment 10

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: "Manage pop-up and third-party redirect settings" button in the blocked pop-up notification will be partially broken (it will lead to the settings page but not scroll down to the correct settings entry).
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: See Bug 2020354
• Risk associated with taking this patch: low
• Explanation of risk level: This patch is just adding two missing data-subcategory attributes to the Privacy & Security settings page, which has little to no breakage potential.
• String changes made/needed: No
• Is Android affected?: no

Comment 11

[Malte Jürgens [:maltejur]]

Attachment: Bug 2020354 - Fix missing subcategories for links in privacy & security settings

These were previously located in
browser/components/preferences/privacy.inc.xhtml and seem to have not been
migrated.

"privacy-sitedata" is still used here:
https://searchfox.org/firefox-main/rev/3c918058f580ec2cd39d80c9f77ccd06982c0029/browser/base/content/browser.js#1093

"privacy-permissions-block-popups" is still used here:
https://searchfox.org/firefox-main/rev/3c918058f580ec2cd39d80c9f77ccd06982c0029/browser/modules/PopupAndRedirectBlockerObserver.sys.mjs#389

From searching through the code, these should be all that are still missing for
the privacy & security settings page.

Original Revision: https://phabricator.services.mozilla.com/D285508

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ce6322c4ad41
https://hg.mozilla.org/releases/mozilla-beta/rev/f2150de221f0

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ee53247397ed
https://hg.mozilla.org/releases/mozilla-release/rev/df21cb93e7f7

Comment 14

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 150.0a1 (2026-03-09) , Beta 149.0b6 and Release 148.0.2