2021447 - New Felt error pages should have “Try again” button autofocused

Status: RESOLVED FIXED

(Firefox :: Security, defect, P1)

Description

[Jan Moesen]

The new Felt error pages enabled in Firefox Nightly do not autofocus the “Try again” button, so it is not possible to try again using a simple press of the space bar or Enter key. The old-style error pages (after toggling the security.certerrors.felt-privacy-v1 pref) still autofocus. (See also: bug 301471.)

I put this in the “Security” component because bug 2017378 and the others are in there, too. Sorry if it is not appropriate. Tested on latest Nightly macOS build: https://hg.mozilla.org/mozilla-central/rev/887fb4b92f0ce8fab484377f1715d972ead217cc

Comment 1

[Manuel Bucher [:manuel] {{ FYI: OOO Jul 30 - Aug 16 }}]

@jbrown: Can you please take a look? This might be an accessibility concern, so from my POV would be good to address before this hits release, but feel free to reasses.

Putting bug enabling the new error page in release as regressing bug.

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2017378

Comment 3

[Jack Brown]

I agree that the "try again" button should still autofocus to preserve the behavior from the original pages.

We're adding access keys to all buttons on the error pages in D283791 for bug 404501 as well, but that's not meant to be a replacement for the button autofocus.

Comment 4

[Jack Brown]

Attachment: Bug 2021447 - Autofocus "Try Again" button in Felt Privacy error pages - r=niklas

Comment 5

[❌ Anna Yeddi [:ayeddi] ❌ On leave until 2027-01-04]

Attachment: Accessibility DevTools in Firefox showing the Try Again being included in an unlabeled ARTICLE container

While this approach would be acceptable for a page with the single control (that is being auto-focused), it would be beneficial to still allow a user of assistive technology (such as a screen reader) to get full information that is visually presented on the page before the button thus would likely to be skipped when focus is forced on the later content.

In this case, adding aria-labeledby on the unlabeled <article> element that would reference the id of the first heading element and adding aria-describedby referencing to the ids of the remaining 3 text and heading elements in this article (or even to the article itself) would allow a blind user to still know which text-only information is visually presented on the page above this autofocused control (and avoid an increasing the severity of the accessibility bug and blocking users from the important information about why they're "trying again").

Comment 6

[Lesley Norton [:lnorton]]

:jbrown please request uplift to beta once this has landed in 150. thank you!

Comment 7

[Pascal Chevrel (relman team) -> :pascalc|PTO until Sept 2]

We are in RC week and the issue was not fixed, it seems unlikely that it will make it into 149 now since the beta cycle is ending. Setting it as fix-optional for a potential inclusion in the planned dot release.

Comment 8

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2017378

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d2a7769a7520
https://hg.mozilla.org/integration/autoland/rev/0acdc3086f96
Autofocus "Try Again" button in Felt Privacy error pages - r=niklas,ayeddi

Comment 10

[amarc]

https://hg.mozilla.org/mozilla-central/rev/0acdc3086f96

Comment 12

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:jbrown, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Jack Brown]

Attachment: Bug 2021447 - Autofocus "Try Again" button in Felt Privacy error pages -

Original Revision: https://phabricator.services.mozilla.com/D286410

Comment 14

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Keyboard and screen reader users who encounter Felt Privacy error pages must manually tab to the "Try Again" button. Autofocusing it immediately on load is standard accessibility practice for error pages (matching the existing behavior for the pref-reset button). Declining delays an a11y improvement for users already seeing the redesigned error page in beta.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This is a purely additive change. The new focusTryAgainButton() method mirrors the existing focusPrefResetButton() pattern. The only other change is adding aria-labelledby/aria-describedby attributes to the article container. No existing code paths were modified.
• String changes made/needed?: No
• Is Android affected?: no

Comment 15

[Jack Brown]

Yeah, this is an accessibility feature, so I think it's important enough for an uplift. I just requested an uplift to beta.

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e7bc776b22b3
https://hg.mozilla.org/releases/mozilla-beta/rev/c364f6cdce78