2021832 - Remove special cases when converting WebDriver types to Marionette

Status: RESOLVED FIXED

(Testing :: geckodriver, task, P3)

Description

[Alexandra Borovova [:Sasha]]

In the scope of bug 1925272, we introduced a helper function, "serialize_to_map" to serialize the parameters when sending Marionette commands. We can now refactor other commands to use it instead of serializing for each command manually.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 2021832 - Remove special cases when converting types to marionette

We only need the special-case path in
MarionetteCommand::from_webdriver_message if we don't have a
marionettte_rs::webdriver::Command variant for the the marionette
command, which is generally only the case for complex commands where
defining parallel types was to much overhead.

Comment 2

[James Graham [:jgraham]]

I started writing a comment about why I didn't like this idea, but ended up with a patch that does what I think we should do instead, which is to follow the pattern where try_convert_to_marionette (now just called to_marionette) handles all the input types, and we avoid having some that go through a different special cased codepath.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3f2ee33a87d6
https://hg.mozilla.org/integration/autoland/rev/150280446fd0
Remove special cases when converting types to marionette r=geckodriver-reviewers,whimboo

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/150280446fd0