2023928 - Control+shift+up/down keboard shortcut doesn't work with NVDA for reorderable moz-box-group elements

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Hanna Jones [:hjones]]

We should add proper roles to elements in moz-box-group when it is type="list" or type="reorderable-list". In those cases we should add role="list" to this element and role="option" to these elements.

Comment 1

[Hanna Jones [:hjones]]

Changing the title and re-classifying this as a bug to get a sense of accessibility severity. According to this comment adding the proper roles should fix the issue.

Comment 2

[Morgan Reschenberg [:morgan]]

Carrying over access-S2 from the originating bug

Comment 3

[akulyk]

Attachment: WIP: Bug 2023928 - Add reorder position announcements and screen reader instructions to reorderable moz-box-group r=#recomp-reviewers

Comment 4

[Finn Terdal (he/they)]

Is this a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=2024029 ?

Comment 5

[Finn Terdal (he/they)]

Wait nevermind, this bug is about the key shortcuts being overriden in NVDA, which is different than 2024029. Sorry for the false alarm

Comment 8

[akulyk]

Attachment: Bug 2023928 - Control+shift+up/down keboard shortcut doesn't work with NVDA for reorderable moz-box-group elements r=#recomp-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0d733a29b882
https://hg.mozilla.org/integration/autoland/rev/2966dbf9d076
Control+shift+up/down keboard shortcut doesn't work with NVDA for reorderable moz-box-group elements r=tgiles

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cf6ecc32b392
https://hg.mozilla.org/integration/autoland/rev/45c74f872a40
Revert "Bug 2023928, Bug 2001218 - Control+shift+up/down keboard shortcut doesn't work with NVDA for reorderable moz-box-group elements r=tgiles" for causing failures at browser_aiwindow_applied_memories_button.js.

Comment 11

[Atila Butkovits]

Backed out for causing failures at browser_aiwindow_applied_memories_button.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/45c74f872a40

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2966dbf9d076a7ebe8538ac9fe9d80508e1c9471&selectedTaskRun=Qh8OWV5pS2iPFJ0ZGvOAsA.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=569153456&repo=autoland&task=Qh8OWV5pS2iPFJ0ZGvOAsA.0&lineNumber=13813

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/60ae2ac83166
https://hg.mozilla.org/integration/autoland/rev/204f0930b288
Control+shift+up/down keboard shortcut doesn't work with NVDA for reorderable moz-box-group elements r=tgiles

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/204f0930b288

Comment 14

[akulyk]

Attachment: Bug 2023928 - Control+shift+up/down keboard shortcut doesn't work with NVDA for reorderable moz-box-group elements

Original Revision: https://phabricator.services.mozilla.com/D302191

Comment 15

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: A major accessibility improvement for the reorderable moz-box-group in Settings. Without this change keyboard navigation and keyboard shortcut reordering won't work with NVDA turned on
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: 1. Open Nightly with NVDA running.

2. Navigate to about:preferences#search.
3. Tab into the "Search Engines" list and focus a reorderable search engine.
4. Press Ctrl+Shift+ArrowDown/ArrowUp to reorder the engine.

• Risk associated with taking this patch: low
• Explanation of risk level: reorderable moz-box-group is used only in settings at the moment as component is relatively new
• String changes made/needed?: no string changes
• Is Android affected?: no

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/30f4c7511c69
https://hg.mozilla.org/releases/mozilla-beta/rev/a86177a20d0d

Comment 17

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the latest Fx153.0a1 on Windows. Engines are correctly re-ordered using ctrl+shift+ArrowDown/ArrowUp with NVDA screenreader on. Waiting for the beta build for verification.

Comment 18

[Cristian Baica [:cbaica], Release Desktop QA]

Closing the issue as verified fixed for the 152 branch as well. Engines are re-odered using ctrl+shift+ArrowDown/ArrowUp with NVDA screenreader on. The re-ordering is no longer done correctly, but that is tracked in bug 2047491.