Closed Bug 2029183 Opened 3 months ago Closed 18 days ago

Support neutral variant of moz-button

Categories

(Toolkit :: UI Widgets, task)

task

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: dwhisman, Assigned: dwhisman)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp-nova] [acorntractors])

Attachments

(1 file)

For moz-button, take any applicable CSS variables and convert them into JSON with a *.tokens.json file following design token naming conventions. Running ./mach buildtokens should build a *.tokens.css file. The toolkit/content/jar.mn file should be updated to add the new tokens CSS file, which should be imported by the CSS file that previously defined the variables.

Assignee: nobody → dwhisman
Status: NEW → ASSIGNED

From :jooliver:

We already have button.tokens.json, this bug should focus on adding the neutral variant to it, which will require adding tokens for the non-nova version so that the import script from Figma can pick up the nova versions.

Summary: Convert moz-button variables into JSON design tokens → Support neutral variant of moz-button
Attachment #9567945 - Attachment description: WIP: Bug 2029183 - Support neutral variant of moz-button r=#reusable-components-reviewers-rotation → Bug 2029183 - Support neutral variant of moz-button r=#reusable-components-reviewers-rotation
Duplicate of this bug: 2024707
Attachment #9567945 - Attachment description: Bug 2029183 - Support neutral variant of moz-button r=#reusable-components-reviewers-rotation → WIP: Bug 2029183 - Support neutral variant of moz-button r=#reusable-components-reviewers-rotation
Attachment #9567945 - Attachment description: WIP: Bug 2029183 - Support neutral variant of moz-button r=#reusable-components-reviewers-rotation → Bug 2029183 - Support neutral variant of moz-button r=#reusable-components-reviewers-rotation
Attachment #9567945 - Attachment description: Bug 2029183 - Support neutral variant of moz-button r=#reusable-components-reviewers-rotation → WIP: Bug 2029183 - Support neutral variant of moz-button r=#reusable-components-reviewers-rotation
Whiteboard: [recomp] [acorntractors] → [recomp-nova] [acorntractors]
Attachment #9567945 - Attachment description: WIP: Bug 2029183 - Support neutral variant of moz-button r=#reusable-components-reviewers-rotation → Bug 2029183 - Support muted variant of moz-button r=#reusable-components-reviewers-rotation
Pushed by dwhisman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/922e2c4ae703 https://hg.mozilla.org/integration/autoland/rev/474e8f4be525 Support muted variant of moz-button r=desktop-theme-reviewers,jules,mconley,ip-protection-reviewers,mlucks,rking
Status: ASSIGNED → RESOLVED
Closed: 18 days ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: