Closed Bug 2031312 Opened 6 months ago Closed 4 months ago

Enable the updated bookmarks panel in Nightly only

Categories

(Firefox :: Sidebar, task)

Product:
Firefox
Component:
Sidebar
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
154 Branch
Tracking Flags:
Tracking Status
firefox154 --- fixed

People

(Reporter: kcochrane, Assigned: kcochrane)

References

(Blocks 1 open bug, Regressed 1 open bug,
URL
)

Details

(Whiteboard: [fidefe-sidebar])

Attachments

(1 file)

Bug 2031312 - Enable the updated bookmarks panel in Nightly
48 bytes, text/x-phabricator-request
Details | Review

Once we land bug 2031288 and bug 2031289 (along with other bugs in the updated-bookmarks-panel meta bug 2024700), we should enable the new bookmarks panel in Nightly only via the sidebar.updatedBookmarks.enabled pref.

Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Blocks: updated-bookmarks-panel
Depends on: 2034096, 2030764
No longer depends on: 2030764
Depends on: 2030764
Depends on: 2030988
Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/626b8ba9073e https://hg.mozilla.org/integration/autoland/rev/ec0ec763797f Revert "Bug 2031312 - Enable the updated bookmarks panel in Nightly r=sclements" for causing mass bc failures

Backed out for causing mass failures

Flags: needinfo?(kcochrane)
Depends on: 2037117
No longer depends on: 2037117
Flags: needinfo?(kcochrane)
Depends on: 2037117
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2acee9c98c40 https://hg.mozilla.org/integration/autoland/rev/de12ba2e9905 Revert "Bug 2031312 - Enable the updated bookmarks panel in Nightly r=sclements" for causing bc failures.

Backed out for causing bc failures.

Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/659b1c484ed2 https://hg.mozilla.org/integration/autoland/rev/87ad330d99f3 Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d490bb8569aa https://hg.mozilla.org/integration/autoland/rev/be260b695181 Revert "Bug 2031312 - Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl" for causing multiple mochitests failures.

Reverted this because it was causing multiple mochitests failures.

Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/27ce65289129 https://hg.mozilla.org/integration/autoland/rev/7112a56678f0 Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c0863aada4de https://hg.mozilla.org/integration/autoland/rev/ffcf621efa16 Revert "Bug 2031312 - Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl" for causing bc failures at context_menu_contents.js

Backed out for causing bc failures at bookmark_context_menu_contents
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/places/tests/browser/browser_bookmark_context_menu_contents.js | test_sidebar_folder_contextmenu_contents - Uncaught exception in test - TypeError: can't access property "selectItems", tree is null

Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d9aafa607ae1 https://hg.mozilla.org/integration/autoland/rev/6005c46766e6 Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl
Pushed by imoraru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1dfa55cbbc36 https://hg.mozilla.org/integration/autoland/rev/0c141f017be3 Revert "Bug 2031312 - Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl" for causing bc failures on browser_CustomKeys.js.

Revert for causing bc failures on browser_CustomKeys.js.

Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6e32b4962597 https://hg.mozilla.org/integration/autoland/rev/e9358a356b31 Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl

https://hg.mozilla.org/mozilla-central/rev/e9358a356b31

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Regressions: 2039954
Regressions: 2040087
Regressions: 2040089
Regressions: 2040090
Regressions: 2040141
Regressions: 2040154
Regressions: 2040189
Regressions: 2040191
Regressed by: 2040142
No longer regressed by: 2040142
Regressions: 2040142

Requesting backout on this until we get some higher priority regressions sorted

Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/991f3cfdd815 https://hg.mozilla.org/integration/autoland/rev/6a10ff641560 Revert "Bug 2031312 - Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl" as requested by dev.
Status: RESOLVED → REOPENED
status-firefox152: fixed → ---
Resolution: FIXED → ---
Target Milestone: 152 Branch → ---
Regressions: 2040356
Regressions: 2040357
Depends on: 2040394
No longer depends on: 2040394
Regressions: 2040394
Depends on: 2039954
No longer regressions: 2039954
Depends on: 2040087
No longer regressions: 2040087
Depends on: 2040089
No longer regressions: 2040089
Depends on: 2040090
No longer regressions: 2040090
Depends on: 2040141
No longer regressions: 2040141
Depends on: 2040142
No longer regressions: 2040142
Depends on: 2040154
No longer regressions: 2040154
Depends on: 2040189
No longer regressions: 2040189
Depends on: 2040191
No longer regressions: 2040191
Depends on: 2040287
No longer regressions: 2040287
Depends on: 2040356
No longer regressions: 2040356
Depends on: 2040357
No longer regressions: 2040357
Depends on: 2040394
No longer regressions: 2040394
Depends on: 2041702
See Also: → 2041924
See Also: → 2041947
No longer depends on: 2040087
See Also: → 2040087
See Also: → 2043613
See Also: → 2044392
Blocks: 2044392
See Also: 2044392 →
No longer blocks: 2044392
Depends on: 2044392
URL: 2040189
No longer depends on: 2040189
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/35b1508a2075 https://hg.mozilla.org/integration/autoland/rev/816bcb9af95b Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl
Pushed by amarc@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/378a8edf75ef https://hg.mozilla.org/integration/autoland/rev/7b3b1e36d1c4 Revert "Bug 2031312 - Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl" for causing bc failures @ browser_testShareBookmarksFromSidebar

Backed out for causing bc failures

Flags: needinfo?(kcochrane)
Flags: needinfo?(kcochrane)
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/088393a81ac3 https://hg.mozilla.org/integration/autoland/rev/d17b470c3372 Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7510934b5986 https://hg.mozilla.org/integration/autoland/rev/ca3c79e2e673 Revert "Bug 2031312 - Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl" for causing linting failure.
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/601b91b1a697 https://hg.mozilla.org/integration/autoland/rev/3928af887813 Enable the updated bookmarks panel in Nightly r=sclements,extension-reviewers,rpl

https://hg.mozilla.org/mozilla-central/rev/3928af887813

Status: REOPENED → RESOLVED
Closed: 5 months ago → 4 months ago
status-firefox154: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Depends on: 2048272
Regressions: 2048272
No longer depends on: 2048272
No longer regressions: 2048272
See Also: → 2048272

:kcochrane did you want to nominate this for nightly release notes?

Flags: needinfo?(kcochrane)
Depends on: 2049285
Regressions: 2049291

(In reply to Dianna Smith [:diannaS] from comment #30)

:kcochrane did you want to nominate this for nightly release notes?

Ania is going to do this today, thanks

Flags: needinfo?(kcochrane)
No longer depends on: 2049285
See Also: → 2049285
Regressions: 2049187
QA Whiteboard: [qa-triage-done-c155/b154]
Regressions: 2058530
No longer regressions: 2058530
Regressions: 2058530
No longer regressions: 2058530
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: