2032196 - Search mode switcher no longer respects density settings

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Sam Johnson]

After bug 1998985, the search mode switcher no longer respects density settings (such as compact mode) and uses the same sizing for each density. This results in a somewhat comically large menu for users of compact mode.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1998985

:mbeier, since you are the author of the regressor, bug 1998985, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Sam Johnson]

Attachment: Bug 2032196 - Use density-aware variables for search mode switcher padding. r?#urlbar-reviewers

This will probably be redone by bug 1826841, but this patch prevents regressing the compact density in 151 by using existing appropriate density-aware variables. With normal density, these variables have the same values that were already set here, so there is no visual change.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/55475eb58481
https://hg.mozilla.org/integration/autoland/rev/4446ec23bd67
Use density-aware variables for search mode switcher padding. r=urlbar-reviewers,desktop-theme-reviewers,dao

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4446ec23bd67

Comment 5

[Sam Johnson]

Attachment: Bug 2032196 - Use density-aware variables for search mode switcher padding.

This will probably be redone by bug 1826841, but this patch prevents regressing the compact density in 151 by using existing appropriate density-aware variables. With normal density, these variables have the same values that were already effective here, so there is no visual change.

Original Revision: https://phabricator.services.mozilla.com/D294860

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Compact density users will experience a much larger menu than expected.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Minor CSS changes
• String changes made/needed?: none
• Is Android affected?: no

Comment 7

[Dão Gottwald [:dao]]

(In reply to Phabricator Automation from comment #6)

• Code covered by automated testing?: yes

I don't think that's true?

• Fix verified in Nightly?: yes
• Needs manual QE testing?: no

Not formally verified yet, but I see it's on QA's radar.

• Steps to reproduce for manual QE testing:

In about:config, change browser.uidensity to 1, then open the search mode switcher.

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e53cd5fd3a0b
https://hg.mozilla.org/releases/mozilla-beta/rev/ff222b49495b

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2026-04-15 Firefox Nightly build on Windows 10.

Verified as fixed on Firefox Nightly 152.0a1 and Firefox 151.0.b1-build2 on Windows 10, Ubuntu 22, macOS 15.