Open Bug 2033943 Opened 3 months ago Updated 1 month ago

Redirecting bookmark favicons disappear since a while (140.9.0esr (64-Bit) OpenSUSE LEAP 15.6)

Categories

(Firefox :: Bookmarks & History, defect, P3)

Product:
Firefox
Component:
Bookmarks & History
Version:
Firefox 140
Type:
defect

Tracking

()

People

(Reporter: bindidon, Unassigned)

References

(Depends on 1 open bug)

Details

Since a few weeks I'm faced with a new look after boot: no bookmark favicon visible anywhere.
There is a tool to repair... I tried it, but it would take many hours to restore them all (about 3,000).

I have seen 'https://bugzilla.mozilla.org/show_bug.cgi?id=401092' as 'VERIFIED FIXED' but it just happened to me again upon a Firefox crash.

if you have a favicons.sqlite.corrupt file in the profile folder, it's likely what happened. Ideally a crash should not cause a database corruption, can you tell us more about the filesystem you're using where the profile folder is located?

If you use an external tool (Either sqlite3.exe from official sqlite.org site, or the tool from https://sqlitebrowser.org/) and run PRAGMA integrity_check on that favicons.sqlite.corrupt file, what does it say?

Flags: needinfo?(bindidon)

Hello Mr Bonardo,
sorry: I was quite busy yesterday; thanks for quick reaction.

The UNIX tool 'find' could not detect any file named 'favicons.sqlite.corrupt' within my entire user area.

The file system containing nearly all data on my notebook is of type 'btrfs', since years above any suspicion, no corrupt file detected since many years.

Hint: I use in parallel to Firefox also TOR - a browser whose behavior lets any one suppose family links to Firefox. Is this a potential problem?

Rgds
jpd

Flags: needinfo?(bindidon)

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(mak)

(In reply to Pengolino from comment #0)

There is a tool to repair... I tried it, but it would take many hours to restore them all (about 3,000).

Which tool is that?
Potentially these tools may make the situation worse, since they can't predict when we make changes to the database schema.

(In reply to Pengolino from comment #2)

Hint: I use in parallel to Firefox also TOR - a browser whose behavior lets any one suppose family links to Firefox. Is this a potential problem?

No, unless you forcibly point them to share the same profile folder, by default they'd store their data into separate profiles, so a problem in one of them would not affect the other one.

There's a few things I'd like to ask:

  1. check in about:config that browser.chrome.site_icons is set to true
  2. run Integrity check in the Places Database section of about:support, does it report any errors?
  3. If you try clicking on multiple bookmarks, none of them gets an icon? I'm trying to understand if nothing shows icons, or rather icons disappeared but revisiting the site is setting them up properly
  4. Do you have any security add-ons or third party software that may be blocking connections?
Flags: needinfo?(mak) → needinfo?(bindidon)

(in reply to [:mak] Comment 4)

Which tool is that?
Fav Icon Refresher (I never used it again, as it apparently runs all web sites for icon refresh!)
*
-> TOR: OK, I never told the guy to do anything like that.
*
browser.chrome.site_icons of course true; otherwise how could I see them?
*
Integrity check's output:

Task: checkIntegrity

  • The places.sqlite database is sane
  • The favicons.sqlite database is sane

Task: checkCoherence

  • The database is coherent

Task: expire

  • Database cleaned up

Task: vacuum

  • Initial database size is 35840KiB
  • The database has been vacuumed
  • Final database size is 30720KiB

... or rather icons disappeared but revisiting the site is setting them up properly: true (if the site does anyway; lemonde.fr doesn't for example)
*
Only add-ons like uBlock Origin and Ghostery

**
Further hint: the problem started if I well remember with the Firefox revision associated to OpenSUSE Leap 15.6.
It never occured before - except once many years ago after a big Firefox crash.

Flags: needinfo?(bindidon)

If I understood correctly, if you revisit some of the bookmarks the icons reappear, but for certain bookmarks they don't?
Can you share some of those "broken" URLs that are not privacy-sensitive? In particular I'm interested in the URL stored in the bookmark, so edit the bookmark and copy the URL from there.

(in reply to [:mak] Comment 4)
Which tool is that?
Fav Icon Refresher (I never used it again, as it apparently runs all web sites for icon refresh!)

add-ons are ok, my concern was with third party external software.

Flags: needinfo?(bindidon)

If I understood correctly, if you revisit some of the bookmarks the icons reappear, but for certain bookmarks they don't?
Correct.

Bookmarks without favicon redisplay:
Name {empty}
http://www.lemonde.fr/

Name TinyURL
https://tinyurl.com/app
etc

Flags: needinfo?(bindidon)

Hello again, Marco Bonardo

After editing Le Monde's ancient bookmark (http +:= s), the favicon appeared.
Same editing for Google: no result.

it's probably a redirect issue, those bookmark URLs likely changed with time, the bookmarks system is not very keen on redirects and if there's more than 1 level of redirecting we may lose track of icons.
I suspect what happened is the system expired some icons that were updated a lot of time ago (> 6 months) because due to multiple redirects it couldn't figure out those icons were still in use by a bookmark.
Similar to Bug 2029384, related to Bug 1999939

The second url may also be a page that is not serving a favicon correctly, since it's generic I cannot verify that.

There's some work to do to properly support these redirects, but at least this is not a case of file corruption.

Severity: -- → S3
Status: UNCONFIRMED → NEW
Depends on: 1999939
Ever confirmed: true
Priority: -- → P3
See Also: → 2029384
Summary: All bookmark favicons regularly disappear since a while (140.9.0esr (64-Bit) OpenSUSE LEAP 15.6) → Redirecting bookmark favicons disappear since a while (140.9.0esr (64-Bit) OpenSUSE LEAP 15.6)

Hello Mr Bonardo,

  1. " it's probably a redirect issue "
    What do you understand here with " redirect " ?
  2. Maybe you are underestimating the fact that until the Firefox revisions which came together with OpenSUSE Leap 15.6, the favicons never disappeared - except years ago after a BIG crash of... Firefox.

Rgds
jpd

(In reply to Pengolino from comment #10)

  1. " it's probably a redirect issue "
    What do you understand here with " redirect " ?

The fact is we mishandle (or not handle at all) URLs that redirect to another URL. So when reloading the page it may not fetch a favicon for the bookmark.

  1. Maybe you are underestimating the fact that until the Firefox revisions which came together with OpenSUSE Leap 15.6, the favicons never disappeared - except years ago after a BIG crash of... Firefox.

Some favicons may have disappeared as consequence of expiration. And the due to the above redirect issue they would not get a new icon.

For ALL the icons to disappear, I can only theorize these cases:

  1. the favicons.sqlite database was replaced (but then there should a favicons.sqlite.corrupt in the profile folder)
  2. the places.sqlite database was replaced (there should be a places.sqlite.corrupt file in the profile folder)

Hello again Mr Bonardo,

"
the favicons.sqlite database was replaced (but then there should a **favicons.sqlite.corrupt **in the profile folder)
the places.sqlite database was replaced (there should be a places.sqlite.corrupt file in the profile folder)
"

if under UNIX and derivates running as superuser /bin/find doesn't find any of the two within my home data, than none of them exists.

I myself never replaced any 'sqlite database'.

Rgds
jpd

You need to log in before you can comment on or make changes to this bug.