2036193 - [Feedback MVP] Add feedback modal for thumbs up/down

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, task)

Description

[Justin Levinsohn]

When a user clicks thumbs up or thumbs down, open a feedback modal to collect user input.

• Feedback UI is only available when pref smartwindow.user_feedback_collection is enabled
• Clicking thumbs up or thumbs down opens the feedback modal
• Modal uses the existing modal component
• Modal includes:
  • title
  • checkbox-based feedback reasons
  • freeform feedback textarea (optional)
  • Cancel button
  • Submit button
  • close (x) button
• User can select one or more checkbox reasons
• User can enter optional freeform feedback
• Cancel and close actions dismiss modal with no submission
• Submitting feedback captures:
  • feedback type (thumbs up / thumbs down)
  • selected reasons
  • freeform text
• Modal content and layout match design
• No preview report or JSON display in this version

Comment 1

[echa]

Attachment: Bug 2036193 - Add feedback modal for thumbs up/down r?pdahiya

• Added a Spotlight-based user feedback modal
• Wired thumbs up/down interactions in assistant response to open the feedback modal via a new FeedbackModal module

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8a6bec04cd83
https://hg.mozilla.org/integration/autoland/rev/8056c20d2d99
Revert "Bug 2036193 - Add feedback modal for thumbs up/down r=pdahiya,fluent-reviewers,omc-reviewers,hanna_a,bolsson" for causing aboutwelcome related failures.

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for causing aboutwelcome related failures.

Push with failures

Failure log

Backout link

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9716e4384230
https://hg.mozilla.org/integration/autoland/rev/b54824282dc0
Add feedback modal for thumbs up/down r=pdahiya,fluent-reviewers,omc-reviewers,hanna_a,bolsson

Comment 5

[echa]

Regenerated the aboutwelcome.css bundle which was required in addition to the asrouter bundle after CSS was split across two files.

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b54824282dc0

Comment 7

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly build 153.0a1 (2026-05-20), please note that this bug only implements the functionality and the Modals UI are not displayed exactly as they are in figma yet.

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: UI for Modal triggered by thumbs up/thumbs down buttons in Smart Window assistant responses. Without this patch, thumbs up/down buttons will not trigger UI.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: - Open Smart Window and enable pref browser.smartwindow.userFeedbackCollection
• Chat with assistant
• Click thumbs up and thumbs down
• Modal with correct content for positive and negative feedback should appear
• Risk associated with taking this patch: low
• Explanation of risk level: Low: feature is gated behind a pref. No other functionality affected.
• String changes made/needed?: No
• Is Android affected?: unknown

Comment 9

[echa]

Attachment: Bug 2036193 - Add feedback modal for thumbs up/down

• Added a Spotlight-based user feedback modal
• Wired thumbs up/down interactions in assistant response to open the feedback modal via a new FeedbackModal module

Original Revision: https://phabricator.services.mozilla.com/D297920

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2cbaea14fcda
https://hg.mozilla.org/releases/mozilla-beta/rev/9dd76ac3de82

Comment 11

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 152.0b2

Comment 12

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: UI for Modal triggered by thumbs up/thumbs down buttons in Smart Window assistant responses. Without this patch, thumbs up/down buttons will not trigger UI.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: - Open Smart Window and enable pref browser.smartwindow.userFeedbackCollection
• Chat with assistant
• Click thumbs up and thumbs down
• Modal with correct content for positive and negative feedback should appear
• Risk associated with taking this patch: low
• Explanation of risk level: Low: feature is gated behind a pref. No other functionality affected.
• String changes made/needed?: No
• Is Android affected?: unknown

Comment 13

[echa]

Attachment: Bug 2036193 - Add feedback modal for thumbs up/down

• Added a Spotlight-based user feedback modal
• Wired thumbs up/down interactions in assistant response to open the feedback modal via a new FeedbackModal module

Original Revision: https://phabricator.services.mozilla.com/D297920

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9588701 [details]
Bug 2036193 - Add feedback modal for thumbs up/down

:echa, see comments on https://phabricator.services.mozilla.com/D302112
The patch failed to land on release due to conflicts.
Bug 2040721 and Bug 2041497 uplifts are blocked since they are in the same stack

Comment 15

[echa]

Thanks :dmeehan! Updated the patch and rebased Bug 2040721 and Bug 2041497

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/f67eef071847
https://hg.mozilla.org/releases/mozilla-release/rev/7100a130bf18

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/ba079482aff4
https://hg.mozilla.org/releases/mozilla-release/rev/7d2838781ee2

Comment 18

[Donal Meehan [:dmeehan]]

Backed out from release due to test failures
Push
Example

Bug 2034623 looks to be a dependency here and is only in 152+