2043714 - DoH custom select UI forgets that it is in custom mode on reload

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Benjamin VanderSloot [:bvandersloot]]

The select reports to be the first element in the list when reloaded with a custom url. This is because the get() happens before the getControlConfig(). Found via Connect: https://connect.mozilla.org/t5/discussions/the-redesign-of-settings-is-now-enabled-by-default-in-nightly/m-p/126794/highlight/true#M50165

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 2043714 - Fix DoH custom select memory - r=manuel!

Comment 2

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1971428

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dd27bcf85335
https://hg.mozilla.org/integration/autoland/rev/6443ac01ab37
Fix DoH custom select memory - r=manuel,Gijs

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6443ac01ab37

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:bvandersloot, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox152 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Benjamin VanderSloot [:bvandersloot]]

We don't need the uplift, so let's not take it to lighten the burden.