Closed Bug 204640 Opened 21 years ago Closed 20 years ago

middle click does not open the link in a new tab (on Mac)

Categories

(Firefox :: General, defect, P2)

Product:
Firefox
Component:
General
Platform:
PowerPC
macOS
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 159986
Milestone:
Firefox1.0beta

People

(Reporter: mitch, Assigned: bugs)

References

Details

(Keywords: platform-parity)

Attachments

(2 files)

browser.js patch
133.68 KB, patch
Details | Diff | Splinter Review
browser.js patch
133.68 KB, patch
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030505 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.4b) Gecko/20030505 Mozilla Firebird/0.6

When using a three button mouse to middle click, or holding down command and
clicking a link, it should open it in a new tab, and it doesn't.

Reproducible: Always

Steps to Reproduce:
1. Open Phoenix.
2. Visit your favorite news site, or any site with links.
3. Hold cmd and click, or with a three button mouse middle click.

Actual Results:  
Nothing happens.

Expected Results:  
Open the link in a new tab (or window - perhaps a preference?).
confirming 20030506

cmd click doesn't do anything (link doesn't open in current window, new window
*or* new tab)
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 205449 has been marked as a duplicate of this bug. ***
fix/workaround given in thread on mozillazine.
http://www.mozillazine.org/forums/viewtopic.php?p=88058#88058

I quote:
"The fix would change the shorcut in Windows and Linux also. Basically in the
function handleLinkClick, change the line:

if (event.ctrlKey) {

to

if (event.metaKey) {

This would change the way the shortcut worked in Windows and Linux. I think the
meta key in Windows is the Windows key."
Attached patch browser.js patch — — Splinter Review 
Here is the actual patch to browser.js that will change the shortcut to
Command-Click.

Note: A method needs to be developed to isolate this change only to the Mac,
since the current patch will change the open in tab shortcut to Meta-Click on
Windows and Linux.
Attached patch browser.js patch — — Splinter Review 
Here is the actual patch to browser.js that will change the shortcut to
Command-Click.

Note: A method needs to be developed to isolate this change only to the Mac,
since the current patch will change the open in tab shortcut to Meta-Click on
Windows and Linux.
I tested Manung's patch.  Command-click on link worked fine on Mozilla
Firebird(2003-05-28-08-trunk and 2003-06-01-08-trunk).  I did not test middle
click of 3-button mouse, because I do not have 3-button mouse(or wheel mouse). 
But, on MacOSX, there are two bugs related to middle button clicking.  One is
bug 151249.  Another is bug 159986.  According to Bugzilla-jp, both Mozilla and
Mozilla Firebird do not respond middle click of mouse.

http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=3198
*** Bug 211821 has been marked as a duplicate of this bug. ***
reassigning mac bugs, sorry for the spam.
Assignee: blake → nobody
--> me.
Assignee: nobody → hyatt
I fixed the cmd+click in numerous places.  Renaming this bug to just talk about
middle+click.
Status: NEW → ASSIGNED
Summary: middle click / cmd-click does not open the link in a new tab → middle click does not open the link in a new tab
Target Milestone: --- → Firebird0.8
*** Bug 216368 has been marked as a duplicate of this bug. ***
Summary: middle click does not open the link in a new tab → middle click does not open the link in a new tab (on Mac)
QA Contact: asa
*** Bug 221343 has been marked as a duplicate of this bug. ***
*** Bug 222282 has been marked as a duplicate of this bug. ***
*** Bug 223590 has been marked as a duplicate of this bug. ***
Summary: middle click does not open the link in a new tab (on Mac) → middle click (command click) does not open the link in a new tab (on Mac)
my bad.  command click is working.
Summary: middle click (command click) does not open the link in a new tab (on Mac) → middle click does not open the link in a new tab (on Mac)
*** Bug 224458 has been marked as a duplicate of this bug. ***
Is there a chance this gets fixed? Tabbed browsing without middleClick is only
half the fun.
Ben, can you field this one?

/be
Assignee: hyatt → bugs
Status: ASSIGNED → NEW
Flags: blocking0.8?
Manung, can you post an actual patch (showing what you've changed, rather than
just the file?
Status: NEW → ASSIGNED
Ben, AFAIK, Manung's patch does not fix the middle-click bug, only the command click bug.  This 
Bug used to refer to both bugs, but the command-click bug was fixed and this bug was made more 
specifc.  
-> .9
Target Milestone: Firebird0.8 → Firebird0.9
ben moved this back to 0.9
Flags: blocking0.8? → blocking0.8-
It should also be noted that middle-click or command-click will not close tabs
either.
Given that this has been narrowed down to just the middle-click behavior on Mac
OS X, shouldn't this be marked as a dup of bug 159986 (which depends on 151249,
which in turn depends on 106692)? Otherwise, discussions and votes will be
scattered.

Alternately, this bug could be renamed to deal with the Command-Click behavior
that it fixed, and then Closed/Fixed.
could this be related to bug 220124 even though it's a different OS?
(In reply to comment #24)
> Given that this has been narrowed down to just the middle-click behavior on Mac
> OS X, shouldn't this be marked as a dup of bug 159986 (which depends on 151249,
> which in turn depends on 106692)? Otherwise, discussions and votes will be
> scattered.

Yes.
The problem by "command+click" which was not able to carry out tab browsing is
already fixed with the OSX version Firefox.
I think that this problem is duplication of bug 159986.
Priority: -- → P2
Target Milestone: Firefox0.9 → Firefox1.0beta
Not having middle click is the primary reason I don't use firefox (or mozilla) in mac os (my primary os). 
the safari middle click may be buggy, but at least it works. i don't see why this is moved back to 1.0, as 
it is really annoying.
> Not having middle click is the primary reason I don't use firefox (or mozilla)
>in mac os (my primary os).  the safari middle click may be buggy, but at least
it > works. i don't see why this is moved back to 1.0, as 
> it is really annoying.

Although I agree that this bug should be fixed, USB overdrive can help you here.
Just map the middle button to Cmd+Click.
"USB overdrive" is a shareware program. I am not purchasing outside software just to use a web 
browser, no matter how much I may enjoy using said browser. Also, using USB overdrive screws up 
default settings for other programs in osx. I am not going to spend all day configuring outside software 
for all my programs, when all I wanted to do is middle click in my web browser.
Keywords: pp
This bug is the main reason why I haven't migrated to Firefox.


*** This bug has been marked as a duplicate of 159986 ***
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → DUPLICATE
i have some problems to use the patch...how can i install it?help please
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: