2046635 - Nova's legacy search bar's switcher menu has an extra separator

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

Before the settings redesign (browser.settings-redesign.enabled), I had unchecked history and bookmarks from the Search Shortcut settings so they weren't included in my address bar's or search bar's suggestions. With the Nova's legacy search bar, the history and bookmarks suggestions are still hidden as expected, but there is an extra separator where they would have been.

Drew says this bug is a regression from bug 2019169.

Comment 1

[Daisuke Akatsuka (:daisuke)]

I investigated this issue.

This was actually handled in CSS at the bug 2019169. [1]
However, after that, the search mode switcher was originally implemented in XUL, we converted it to HTML [2]. As part of that it now uses panel-list[3], whose stylesheet sets display: block !important on slotted hr elements [4], so that rule ended up winning over ours.

[1] https://searchfox.org/firefox-main/rev/8e16ea8e5df0354144902ae0911a5609344bdb6d/browser/themes/shared/urlbar-searchbar.css#1448-1451
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1998985
[3] https://searchfox.org/firefox-main/rev/8e16ea8e5df0354144902ae0911a5609344bdb6d/browser/components/urlbar/content/UrlbarInput.mjs#140
[4] https://searchfox.org/firefox-main/rev/8e16ea8e5df0354144902ae0911a5609344bdb6d/toolkit/content/widgets/panel-list/panel-list.css#77-78

As a fix, I think we can either strengthen our rule with display: none !important in CSS, or explicitly set hidden on the hr via JS. I’ll go with the former for now, but let me know if you have any thoughts.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2046635: Use important to hide the search mode switcher footer separator

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2046635: Hide the footer separator with the hidden attribute when there are no items between the separators

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a4b4b29059fd
https://hg.mozilla.org/integration/autoland/rev/68b78fe0a94e
Hide the footer separator with the hidden attribute when there are no items between the separators r=urlbar-reviewers,adw

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/68b78fe0a94e

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2026-06-10 Firefox Nightly build on Windows 10.

Verified as fixed on Firefox Nightly 153.0a1 on Windows 10, Ubuntu 22, macOS 15.