2048038 - Set Sign in With Thundermail pref to true

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, task)

Description

[Toby Pilling [:tobyp]]

This task is to set the mail.accounthub.thundermail.enabled pref true by default which controls the visibility of the "Sign in with Thundermail" button (and potentially other UI elements in the future).

Comment 1

[Toby Pilling [:tobyp]]

Attachment: Bug 2048038 - Set default value of mail.accounthub.thundermail.enabled to true. r=#thunderbird-reviewers

Comment 2

[Toby Pilling [:tobyp]]

Comment on attachment 9598022 [details]
Bug 2048038 - Set default value of mail.accounthub.thundermail.enabled to true. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: We need this to ride the trains in order to enabled "Sign in with Thundermail" which is already enabled on Android.
• User impact if declined: Less users and interest for Thundermail.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just flips a pref
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: None

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e029e7bc24d8
Set default value of mail.accounthub.thundermail.enabled to true. r=aleca

Comment 4

[Martin Giger [:freaktechnik]]

This is causing failures like https://treeherder.mozilla.org/logviewer?job_id=573379269&repo=comm-central&task=IEZA73DuS5uyafFHfSmP1w.0&lineNumber=8719

The currently visible failure is that https://searchfox.org/comm-central/rev/72b8ba0761b3881d926be53f77fbf75d5a9316d5/mail/test/browser/account/browser_accountHub.js#116-118 finds the thundermail icon and expects it to be hidden.

This is more apparent when applying these changes to the test to see the actual icon URL:

diff --git a/mail/test/browser/account/browser_accountHub.js b/mail/test/browser/account/browser_accountHub.js
--- a/mail/test/browser/account/browser_accountHub.js
+++ b/mail/test/browser/account/browser_accountHub.js
@@ -114,7 +114,7 @@ add_task(async function test_account_ema
   const icons = emailTemplate.querySelectorAll("img");
 
   for (const icon of icons) {
-    Assert.ok(BrowserTestUtils.isHidden(icon), `${icon.src} should be hidden`);
+    Assert.ok(BrowserTestUtils.isHidden(icon), `${window.getComputedStyle(icon).content} should be hidden`);
   }
 
   Assert.ok(

Comment 5

[Corey Bryant]

Comment on attachment 9598022 [details]
Bug 2048038 - Set default value of mail.accounthub.thundermail.enabled to true. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 153.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/f10337fc8981