Closed Bug 2048246 Opened 5 months ago Closed 5 months ago

Broken Account Hub tests following bug 2048038

Categories

(Thunderbird :: Account Manager, defect, P2)

defect
Points:
1

Tracking

(thunderbird_esr140 unaffected, thunderbird153 fixed)

RESOLVED FIXED
154 Branch
Tracking Status
thunderbird_esr140 --- unaffected
thunderbird153 --- fixed

People

(Reporter: tobyp, Assigned: tobyp)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 external file)

We need to adjust mail\test\browser\account\browser_accountHub.js to allow some images (like the "Sign in with Thundermail" button) to appear on initial load of Account Hub

Assignee: nobody → toby
Status: NEW → ASSIGNED

Comment on attachment 9598315 [details]
Bug 2048246 - Adjust browser_accountHub.js test to allow sign-in button images. r=#thunderbird-reviewers

Uplift Approval Request

  • Please state case for uplift consideration and ensure bug severity is set: Needed to fix test failures after bug 2048038
  • User impact if declined: no user impact - but CI test failures
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Daily?: No
  • Has the fix been verified in Beta?: No
  • Needs manual test from QA?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 2048038
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Test fix
  • Does the fix cause any migrations to be skipped?: No
  • String changes made/needed: None
Attachment #9598315 - Flags: approval-comm-beta?
Target Milestone: 153 Branch → 154 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/af6de5c5a362
Adjust browser_accountHub.js test to allow sign-in button images. r=mkmelin,vineet

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED

Comment on attachment 9598315 [details]
Bug 2048246 - Adjust browser_accountHub.js test to allow sign-in button images. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9598315 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: