Closed
Bug 2049912
Opened 2 months ago
Closed 1 month ago
Style app menu update and addon banners consistently for Nova
Categories
(Firefox :: Menus, enhancement)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
154 Branch
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: juliana, Assigned: juliana)
References
(Blocks 2 open bugs, Regression)
Details
Attachments
(2 files)
There are several messages that can appear at the top of the app menu. Bug 2023763 updated the "update-restart" notification for nova but the rest lost some of their styles and are not aligned.
Additionally we want to make some changes how the update-restart notification looks.
To test the states open the browser toolbox and use the following commands:
const { AppMenuNotifications } = ChromeUtils.importESModule(
"resource://gre/modules/AppMenuNotifications.sys.mjs"
);
AppMenuNotifications.showBadgeOnlyNotification("update-restart");
AppMenuNotifications.showBadgeOnlyNotification("update-available");
AppMenuNotifications.showBadgeOnlyNotification("update-downloading");
AppMenuNotifications.showBadgeOnlyNotification("update-manual");
AppMenuNotifications.showBadgeOnlyNotification("update-unsupported");
// AppMenuNotifications.removeNotification(/.*/); // Clear:
// Addon banners:
gExtensionsNotifications._createAddonButton(
"webext-perms-sideload-menu-item",
{ name: "Fake Addon", iconURL: "" },
() => console.log("sideload clicked")
);
gExtensionsNotifications._createAddonButton(
"webext-perms-update-menu-item",
{ name: "Fake Addon" },
() => console.log("update clicked")
);
gExtensionsNotifications._createAddonButton(
"webext-imported-addons",
null,
() => console.log("import clicked")
);
PanelUI.addonNotificationContainer.replaceChildren(); // Clear
| Assignee | ||
Updated•2 months ago
|
Assignee: nobody → git
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•2 months ago
|
||
Updated•2 months ago
|
Attachment #9600671 -
Attachment description: WIP: Bug 2049912 - Updated app menu message styles for Nova. → Bug 2049912 - Updated app menu message styles for Nova.
Blocks: nova-foxfooding
Comment 3•1 month ago
|
||
Please update the App Update copy to reflect the Figma
Headline: 'Restart to update Firefox'
Body: 'Your tabs will reopen.'
Pushed by git@juliana.me:
https://github.com/mozilla-firefox/firefox/commit/7051f30bd7b6
https://hg.mozilla.org/integration/autoland/rev/63165b337fcf
Updated app menu message styles for Nova. r=desktop-theme-reviewers,fluent-reviewers,bolsson,hjones
Comment 7•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox154:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Updated•1 month ago
|
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in
before you can comment on or make changes to this bug.
Description
•