Closed Bug 2049912 Opened 2 months ago Closed 1 month ago

Style app menu update and addon banners consistently for Nova

Categories

(Firefox :: Menus, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: juliana, Assigned: juliana)

References

(Blocks 2 open bugs, Regression)

Details

Attachments

(2 files)

There are several messages that can appear at the top of the app menu. Bug 2023763 updated the "update-restart" notification for nova but the rest lost some of their styles and are not aligned.

Additionally we want to make some changes how the update-restart notification looks.


To test the states open the browser toolbox and use the following commands:

const { AppMenuNotifications } = ChromeUtils.importESModule(
  "resource://gre/modules/AppMenuNotifications.sys.mjs"
);
AppMenuNotifications.showBadgeOnlyNotification("update-restart");
AppMenuNotifications.showBadgeOnlyNotification("update-available");
AppMenuNotifications.showBadgeOnlyNotification("update-downloading");
AppMenuNotifications.showBadgeOnlyNotification("update-manual");
AppMenuNotifications.showBadgeOnlyNotification("update-unsupported");
// AppMenuNotifications.removeNotification(/.*/); // Clear:

// Addon banners:
gExtensionsNotifications._createAddonButton(
  "webext-perms-sideload-menu-item",
  { name: "Fake Addon", iconURL: "" },
  () => console.log("sideload clicked")
);
gExtensionsNotifications._createAddonButton(
  "webext-perms-update-menu-item",
  { name: "Fake Addon" },
  () => console.log("update clicked")
);
gExtensionsNotifications._createAddonButton(
  "webext-imported-addons",
  null,
  () => console.log("import clicked")
);

PanelUI.addonNotificationContainer.replaceChildren(); // Clear
Assignee: nobody → git
Status: NEW → ASSIGNED
Attachment #9600671 - Attachment description: WIP: Bug 2049912 - Updated app menu message styles for Nova. → Bug 2049912 - Updated app menu message styles for Nova.
Duplicate of this bug: 2052254

Please update the App Update copy to reflect the Figma

Headline: 'Restart to update Firefox'
Body: 'Your tabs will reopen.'

Duplicate of this bug: 2050790
Duplicate of this bug: 2053115
Pushed by git@juliana.me: https://github.com/mozilla-firefox/firefox/commit/7051f30bd7b6 https://hg.mozilla.org/integration/autoland/rev/63165b337fcf Updated app menu message styles for Nova. r=desktop-theme-reviewers,fluent-reviewers,bolsson,hjones
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Duplicate of this bug: 2050223
Duplicate of this bug: 2049381
QA Whiteboard: [qa-triage-done-c155/b154]
Regressed by: 2059558
Blocks: 2062751
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: