205001 - the print scale is ignored at using CSS absolute length unit

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Dmitry Kubov]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030507
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030507

Changing scale in preview dialog for this page does not change article body font
size, its stil oversized on A4 page, so prints are ripped.

Reproducible: Always

Steps to Reproduce:
1. Goto http://www.opennet.ru/base/net/bsd_pbr_route.txt.html
2. Open print preview
3. Change scale

Actual Results:  
Only navigation link text ia changed. Article body have fixed size

Expected Results:  
Scale whole page, like text zoom in browser window

Probably this happens on monospace font only

Comment 1

[Dmitry Kubov]

1.4rc2

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4) Gecko/20030612

same bug

Comment 2

[Dmitry Kubov]

still exist

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.6) Gecko/20040113

Comment 3

[James Napolitano]

Confirming the specified behavior with Mozilla/5.0 (Windows; U; Win98; en-US;
rv:1.8a4) Gecko/20040916.  The culprit is merely specifying the font-size CSS
property of the text.

Comment 4

[James Napolitano]

Attachment: testcase

Just go to print preview and change the scale dramatically.  Observe how normal
text is changed in size but text with font-size specified remains the same
size.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

*** Bug 298142 has been marked as a duplicate of this bug. ***

Comment 6

[zug_treno]

*** Bug 264022 has been marked as a duplicate of this bug. ***

Comment 7

[Steven Hunter]

*** Bug 324704 has been marked as a duplicate of this bug. ***

Comment 8

[zug_treno]

*** Bug 325603 has been marked as a duplicate of this bug. ***

Comment 9

[zug_treno]

Reproducible with Firefox 1.5.0.1, SeaMonkey 1.5a/20060202 and even Mozilla 0.9.9. When I set Appearance > Fonts > Minimum font size: to 9 the fonts seem to grow a little at Scale: 200%, but they aren't doubled.

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

We should use current context scaling at resolving fixed length.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: another testcase

I think that this box should be scaled by print scale. But we cannot scale the box by print scale. The patch fixes this issue too.

Comment 12

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 210618 [details] [diff] [review]
Patch rv1.0

I think this is OK but I want dbaron to confirm. This is a pretty fundamental change.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Does this also fix bug 153080?

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Nice testcases are:
http://www.w3.org/Style/CSS/Test/CSS1/current/test61.htm
http://www.w3.org/Style/CSS/Test/CSS1/current/test526.htm

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 210618 [details] [diff] [review]
Patch rv1.0

Not that I understand our units system, but this fix  (which does fix bug 153080) certainly seems sensible -- it matches the problem.  r=dbaron

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 153080 has been marked as a duplicate of this bug. ***

Comment 17

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in to trunk.
I'll request approval 1.8 branch.

Comment 18

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

So this badly broke printing (but not print preview) of absolute length units in Windows and Cairo builds (but not builds using Postscript), since in those cases the canonical pixel scale starts of as non-1.

What we really need is for zoom to be implement some way other than fudging the canonical pixel scale so that we can separate the numbers.  I think I suggested this in pretty early comments in bug 153080.

Stuart is backing this out now, I think.

Comment 19

[Stuart Parmenter]

backed out

Comment 20

[Eli Friedman]

This might be worth working on if somebody is willing to patch this for the 1.8 branch, but the forward-looking solution is to use proper scaling; my patch in bug 177805 does that, but it's waiting on the cairo gfx work because I didn't push to get fixes for all the GFX backends.  I'll write up an update in that bug shortly.

Comment 21

[Eli Friedman]

Fixed by the changes in bug 177805.