205008 - Bookmark a link in history results in a bookmark without location

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Steffen Wilberg]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030504 Mozilla Firebird/0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4b) Gecko/20030504 Mozilla Firebird/0.6

Creating a bookmark out of the history sidebar results in an improper bookmark
without location.

Reproducible: Always

Steps to Reproduce:
1. Open History sidebar.
2. Right-click a link, select "Bookmark This Link", click OK.
3. Open Bookmarks sidebar or Bookmarks Manager.
4. Open Properties of the new bookmark.

Actual Results:  
The Properties window shows only the "Info" tab, an there only the name of the
bookmark.
The source of the bookmarks file shows: ... <dt><a HREF="" ADD_DATE="1052479569" ...
There is no link!
Restart Firebird, and the bookmark is gone.

Expected Results:  
A proper bookmark should be created.

Workaround:
In history, open the page by double-click; or right-click and select open. Then
bookmark the page with Ctrl-D or drag-n-drop from the location bar.

Might be related to Bug 163958, but that one concerns Mozilla.

Comment 1

[noririty]

confirming.

Might be related to Bug 198616.

Comment 2

[Blake Ross]

Fixed.

Comment 3

[noririty]

v.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/browser/components/history/content&command=DIFF_FRAMESET&file=history.js&rev1=1.25&rev2=1.26&root=/cvsroot