Closed Bug 20518 Opened 25 years ago Closed 25 years ago

In Bookmark Dropdown, directories are flickering and redrawing.

Categories

(SeaMonkey :: Bookmarks & History, defect, P3)

x86
Windows NT
defect

Tracking

(Not tracked)

VERIFIED INVALID

People

(Reporter: jelwell, Assigned: hyatt)

References

Details

(Whiteboard: [TESTCASE])

Attachments

(1 file)

This happens on WinNT Build 1999120108 (nightly build) but not on M11.

My bookmark file consists of
The Personal Toolbar, followed by 3 directories, seperator then many single
items.

To reproduce:
0) Have a bookmark file with folders...
1) Hit <CTRL>B
2) Arrow down

Notice whenever you enter or leave a directory the bookmark flickers and for a
second draws items nearby in it's place.
woops! I meant <ALT>B not <CTRL>B (CTRL opens the bookmark manager window, ALT
opens the menu dropdown)

To reproduce:
0) Have a bookmark file with folders...
1) Hit <ALT>B
2) Arrow down, keep going until you go over some folders...
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
It looks ok to me on Windows and Linux.
Marking worksforme.
Status: RESOLVED → REOPENED
slamm what build are you using? it worksforme on m11. but it's broken on
1999120108... One of us doesn't have the newest version?
I just downloaded 1999120113 and it's gotten worse. Now when i arrow down the
whole bookmark dropdown flickers and sometimes selected bookmark changes to
where the mouse is.
Try this:
1) <ALT>B (to open bookmark dropdown).
2) move your cursor to the bottom half of your bookmarks.
3) arrow up. (try to get to "Add Current Page".)

I couldn't make it to "Add Current Page" instead when i reached the first folder
the bookmark under my cursor got highlighted, arrowing up again just makes this
a loop...

I think this is a regression bug. slamm, try downloading a newer build.
Hmm, I was using builds from yesterday. I will take another look.
Resolution: WORKSFORME → ---
Clearing WORKSFORME resolution due to reopen.
I'm currently using Build 1999120315 and with the default bookmarks I get no
flicker and the display is fine. But with _my_ bookmarks file I get flicker and
a bad layout. I've been using the same bookmark since M10... I'm going to try to
minimize the bookmark file to a small test case.
Install the included bookmark file. Then:
1) Hit <ALT>B
2) Place the cursor on the Linuxgames bookmark.
3) Hit the arrow button up. (to try to get to the Personal Toolbar)

Notice you can't arrow up to the personal toolbar. The highlighted selection
goes to wherever your mouse is despite the fact that you didn't move your mouse.
Try to get to the Personal toolbar by going down or up with the arrow keys while
your mouse is above the Linuxgames bookmark.

This just seems to be a bookmark title that's way too long, but I'm fairly
certain that this bookmark file hasn't been a problem in the past.
jelwell, do you tihnk you could take a look at bug 21016 and tell us if you think you trouble might be related?
It's very likely that they are indeed related. This Flickering and moving to the
mouse thing happens in two different test cases.

 The first test case (which is posted above) happens, i think, because one of
the bookmarks "Name" field is too long to be displayed properly by the bookmark
dropdown.

 The other test case, is my current bookmark file - which I haven't posted. It
contains does not contain a bookmark with a very large "Name" field. However it
does contain a too many bookmarks to display on the screen at one time.

So, basically bug 21016 occurs in the second test case, and very well be the end
result of the same problem. Which is the bookmarks dropdown acts funny because
it is failing to draw everything out properly.
Chris, do you know about this?
Assignee: slamm → saari
Status: REOPENED → NEW
Passing to saari.
Yeah, I'm actually working on part of this.
Status: NEW → ASSIGNED
Target Milestone: M14
Assignee: saari → hyatt
Status: ASSIGNED → NEW
Hyatt, you've been working on this right?
Status: NEW → ASSIGNED
hyatt, do you want to keep this or should I take it?
*** Bug 21262 has been marked as a duplicate of this bug. ***
I don't know what's causing this yet.  Wish I did. :)
maybe it's bug 22619
Whiteboard: [TESTCASE]
Bug 22619 describes the flickering problem - but note that bug 22619 is the
Personal Toolbar Bookmarks; whereas this bug is the bookmarks menu option at the
top of the screen.

However the arrow key problem - which is the annoying part because it keeps me
from navigating my bookmarks with the keyboard - does not show up in bug 22619.
That might be unrelated or it might be that because the keybindings for up/down
aren't hooked in at all to the personal toolbar bookmarks (hitting up and down
don't do anything).

Try my attachment test - it shows the flickering and the problem with keyboard
navigation.
*** Bug 22619 has been marked as a duplicate of this bug. ***
The flickering and redrawing happen because we show the menu too early.  We also 
have positioning problems.  Pinkerton has both of these bugs.  There is also a 
third bug open for broken key navigation in menus.  I have that bug.

I am closing this out.  It's a great report, but it describes three problems, 
all of which have bugs filed for them, so I don't think we need to keep this 
around.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → INVALID
VERIFIED
Status: RESOLVED → VERIFIED
hyatt said,"There is also a third bug open for broken key navigation in menus.  
I have that bug."

hyatt: what is that bug number? Because I have a feeling it doesn't describe 
this bug. Which isn't broken navigation so much as buggy navigation when the 
mouse is over a bookmark. I would guess that this bug depends on the broken 
navigation, especially since in winNT build M13 I can't reproduce this bug - 
because indeed keyboard navigation is broken. But when it's fixed, I will not be 
surprised to see this bug re-appear.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: