Open Bug 2051920 Opened 4 months ago Updated 1 month ago

"Built-in VPN" preference row is misaligned with other settings items on a large screen device

Categories

(Firefox for Android :: Settings, defect)

Firefox 153
All
Android
defect

Tracking

()

Tracking Status
firefox153 --- affected

People

(Reporter: alemartin, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid] [android-core])

Attachments

(1 file, 1 obsolete file)

Prerequisites

  • Have VPN feature available in the Firefox Beta app on a large screen device;
  • Open Firefox Beta;

Steps to reproduce

  1. Open Settings > Privacy and security.
  2. Scroll and observe the "Privacy and security" section.

Expected behavior

"Built-in VPN" option is in line with the rest of the menu.

Actual behavior

The "Built-in VPN" item breaks grid alignment and indents further to the left than surrounding items.

Device information

  • Firefox version: 153.0b6 (Build #2016169775)
  • Android device model: Google Pixel C
  • Android OS version: 8.0.0

Any additional information?

A similar bug that we fixed before. If we pick this up, let's find a way to add a test to avoid another regression.

See Also: → 2044382
Assignee: nobody → gmalekpour
Attachment #9605255 - Attachment description: WIP: Bug 2051920 - Set Built-in VPN preference row padding based on the screen size → Bug 2051920 - Set Built-in VPN preference row padding based on the screen size
Blocks: 2037977
No longer blocks: 2022109

Triage: this is a low priority task for VPN, but we believe this is a general problem that all mobile teams will face by using org.mozilla.fenix.settings.ComposePreference, so this might be good for the team owning Settings to consider how to solve this holistically.

Component: Privacy → Settings
Whiteboard: [fxdroid] [group2] → [fxdroid] [android-core]
No longer blocks: 2037977
Assignee: gmalekpour → nobody
Attachment #9605255 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: