Closed Bug 2055150 Opened 1 month ago Closed 14 days ago

[Nova] Remove chrome block borders touching window edges in compact mode

Categories

(Firefox :: Sidebar, defect, P1)

Firefox 154
defect
Points:
1

Tracking

()

RESOLVED WONTFIX

People

(Reporter: mercichao, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-nova])

Attachments

(1 file, 1 obsolete file)

Attached image Region.png

In compact mode, window padding is removed, but the chrome block borders around the window remain visible. This looks inconsistent, especially since the top edge of the top block is missing its border, and the border corners of other blocks are cut off at the window corners.

Blocks: nova-compact
Whiteboard: [fidefe-nova]

The UX spec at https://www.figma.com/design/XT0eDYh4RtbMNWaYQi0efM/Chrome-Sidebar-UX-Specifications--Sprint-1-?node-id=12167-95157&m=dev effectively calls for a 1px border using the chrome separator color around the entire window at all UI densities.

  1. I don't see that 1px border in the codebase now, so I'm checking to see whether the design team intends for us to have it
  2. It looks like the compact mode code changes from bug 2030953 left in some of the individual chrome block borders, which, when they are on the edges of the window, make it look like the window has a border.

Whatever else we do, I think we should remove borders around individual chrome blocks that touch the edge of the window. Thank you for reporting this.

The severity field is not set for this bug.
:jsudiaman, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jsudiaman)
Severity: -- → S4
Flags: needinfo?(jsudiaman)
Priority: -- → P2
Status: UNCONFIRMED → NEW
Ever confirmed: true
Points: --- → 1
Priority: P2 → P1
See Also: → 2061950
Duplicate of this bug: 2061254

Superseded by bug2063294

Status: NEW → RESOLVED
Closed: 14 days ago
Resolution: --- → WONTFIX
Attachment #9624147 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: