2057169 - Top and bottom menu items have their corners cut off by the menupopup's larger border radius

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Dão Gottwald [:dao]]

Attachment: Screenshot From 2026-07-23 10-54-41.png

Comment 3

[Mark Striemer [:mstriemer]]

See bug 2057170 comment 1 from Jules:

This menupopup uses the panel border radius token which with Nova on is now a roundier value. Some of our latest token changes have affected it consequently.

The line is here. We should instead not share styles and make a custom property or token for menupopup border radius and go back to the smaller radius to guarantee it never changes based on what we do with our other panels.

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: WIP: Bug 2057169 - make basic menupopup/panel use a less aggressive radius

Comment 5

[Mark Striemer [:mstriemer]]

WIP patch has some changes for revamping the token usage so --popup- would be for base menupopup, panel and --panel- would be for [type=arrow]. I think that's likely something we want to do going forward but it could use some more thinking through regarding making this distinction more explicit between the different use cases and expanding it to more properties

For now we should consider just modifying the popup.css rules to revert the Nova radius getting increased

Comment 7

[Dustin Whisman [:dwhisman]]

Attachment: Bug 2057169 - Prevent menu items from being cut off by menupopup border radius r=#desktop-theme-reviewers

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fc9537321c2e
https://hg.mozilla.org/integration/autoland/rev/ccd290239c10
Prevent menu items from being cut off by menupopup border radius r=desktop-theme-reviewers,emilio

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ccd290239c10

Comment 13

[Simona Badau, Desktop QA]

Reproduced the initial issue and the ones from the duplicate bugs using Nightly 155.0a1 (Build ID: 20260723204011) on Ubuntu 24.04.

Verified as fixed using the latest Nightly 155.0a1 on Ubuntu 24.04 - the top and bottom of the menus are not cut anymore.