2057771 - [Nova] Panel border radius misaligned with hovered items if compact

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P3)

Description

[Jan Brasna [:janbrasna]]

Attachment: shield-privacy-settings-hovered.png

Similar to bug 2057169, the rounding got too close when the item is highlighted/hovered.

Comment 1

[Jan Brasna [:janbrasna]]

Attachment: shield-lock-hovered.png

Analogously on the opposite edge of the panel as well.

Comment 3

[Jan Brasna [:janbrasna]]

Attachment: nova-compact-radii.png

Adding some more examples where the radii on hover in compact density don't appear exactly aligned, incl. the suggest result context menu, and back buttons in nested menus.

Comment 5

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:jules, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:jules, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[Sam Johnson]

Attachment: Bug 2057771 - Fix Nova compact mode panel border radius concentricity. r?#desktop-theme-reviewers

Updates the menu item radius to reflect reality (the items were displaying with 14px as they are too short to display 16px) and updates the panel radius to be concentric (by adding the now-consistent item radius and the margin together). Because this adds a Nova branch to the file, I took the opportunity to also fix a Proton regression from bug 2059402.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5c46385e59ac
https://hg.mozilla.org/integration/autoland/rev/176b59c71326
Fix Nova compact mode panel border radius concentricity. r=desktop-theme-reviewers,reusable-components-reviewers,akulyk

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/176b59c71326