205974 - [Mac] Missing PrintPDE.plugin: can't print background colors, selection or frames

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[HARUNAGA Hirotoshi]

Mac Mozilla Firebird cannot "Print Background Colors" and "Print Background
Images".

Steps:
Open Menu File -> Print

Result:
There is no "Print Background Colors" or "Print Background Images" option.

Confirming with Mozilla Firebird 20030515 on MacOS 10.2.5.
Mozilla trunk has "Mozilla" dialog in "Print" dialog.

And there is PrintPDE.plugin in Mozilla.app/Contents/Plug-Ins/ on Mozilla,
but Firebird doesn't have "Mozilla Firebird.app/Contents/Plug-Ins" directory.

If I copy Mozilla.app/Contents/Plug-Ins to "Mozilla Firebird.app/Contents",
"Mozilla Firebird" dialog becomes to appear in "Print" dialog.

Related to Bug 202340 and Bug 188508.

Comment 1

[Simon Paquet [:sipaq]]

Taking QA Contact as designated owner of Firebird-Menus. Sorry for bugspam.

Comment 2

[Blake Ross]

reassigning mac bugs, sorry for the spam.

Comment 3

[Mike Connor [:mconnor]]

--> hyatt

Comment 4

[HARUNAGA Hirotoshi]

Attachment: patch

Comment 5

[Hiro]

This patch is required for Thunderbird similarly.

Comment 6

[Hiro]

Although tried also on Firefox and Thunderbird which were created by
AVIARY_1_0_20040515_BRANCH, the background-color-etc.-extended printing property
is working.

Comment 7

[HARUNAGA Hirotoshi]

I can't find that property. Where?
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040611
Firefox/0.8.0+

Comment 8

[Hiro]

(In reply to comment #6)
> Although tried also on Firefox and Thunderbird which were created by
> AVIARY_1_0_20040515_BRANCH, the background-color-etc.-extended printing property
> is working.

Oops...
The patch was applied by the manual...

Comment 9

[HARUNAGA Hirotoshi]

Over to Build Config.

Comment 10

[Jo Hermans]

*** Bug 250403 has been marked as a duplicate of this bug. ***

Comment 11

[Jo Hermans]

Nominating for 1.0.

This plugin (a Mac OS X printer-plugin, not a browser plugin) is missing from
Firefox and Thunderbird builds, but it present in Seamonkey. This causes a
special 'Mozilla' or 'Firefox' tab to appear in the print dialog box, with
options to print selections, background colors and frames. It's generic for all
gecko apps.

It's a super easy checkin, we only have to copy the plugin in the build. In
fact, you can also copy the Contents/Plug-ins folder from Mozilla into the
Firefox package yourself (when you've opened both applications with 'Show
Package Contents'). The plugin even automatically assumes the correct name of
the application (Mozilla/Firefox/Mozilla Tunderbird).

Don't forget to check it in Thunderbird too.

Comment 12

[Jo Hermans]

*** Bug 250816 has been marked as a duplicate of this bug. ***

Comment 13

[Conrad Carlen (not reading bugmail)]

Comment on attachment 130772 [details] [diff] [review]
patch

r=ccarlen.

Comment 14

[Jo Hermans]

Thunderbird bug is bug 261216

Comment 15

[Asa Dotzler [:asa]]

Bryner, Chase, is this a simple packaging change? Is it worth considering for
Firefox 1.0

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 130772 [details] [diff] [review]
patch

a=asa for aviary checkin.

Comment 17

[Brian Ryner (not reading)]

checked into trunk and branch.

Comment 18

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2004110711-0.11 on mac os x 10.3.5. able to print selection
and frames.

Comment 19

[Mikael Hedberg]

Can the strings in English.lproj/PrintPDE.nib/objects.xib be localized somehow
or should I open a new bug about this? The Mac print dialog currently displays
in English even on our sv-SE builds.

Comment 20

[sairuh (rarely reading bugmail)]

(In reply to comment #19)
> Can the strings in English.lproj/PrintPDE.nib/objects.xib be localized somehow
> or should I open a new bug about this? The Mac print dialog currently displays
> in English even on our sv-SE builds.

yes, a separate bug would be good for that issue.

Comment 21

[weijia]

Print Selection is greyed out for me on 11-07 build.

Comment 22

[Brian Ryner (not reading)]

I just tested today's es-ES localized build.  Only the newly-added print options
are in English, so it's not really a regression.  I think that to address this
fully, localizers would need to translate the Localizable.strings file in
English.lproj and place it in a <Language>.lproj directory.  (I'm not 100% sure
about that)  At any rate, it's too late to require localizers to translate this
file, but I think having this functionality there in English is better than not
having it at all.

Also, print selection works fine here, just make sure you actually have some
text selected.

Comment 23

[Stefan [:stefanh]]

See bug 268309 for the localization issue.

Comment 24

[weijia]

To elaborate on my earlier post, I realized that if your printer Presets is
something other than "Standard", the print selection and the frames options will
be greyed out.  Reproducible by simply saving a profile.