Selecting 'Hide tabs and sidebar' and closing the menu causes the collapsed sidebar to show
Categories
(Firefox :: Sidebar, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: pannett, Assigned: sclements)
References
Details
(Whiteboard: [fidefe-sidebar])
Attachments
(1 external file)
Steps to reproduce:
- Enable vertical tabs
- Select the settings gear in the sidebar
- Select 'Hide tabs and sidebar'
- The vertical tabs immediately hide, as expected
- Close the sidebar
Expected:
6. Tab strip should remain closed
7. I can open it using the 'show sidebar' button in the toolbar
Actual:
6. Tab strip wrongly opens in its narrow state
7. Clicking the 'show sidebar' button in the toolbar closes it, and a second click opens the tab strip in its wide state
Comment 1•2 months ago
|
||
The severity field is not set for this bug.
:sfoster, could you have a look please?
For more information, please visit BugBot documentation.
Comment 2•2 months ago
|
||
Thanks for filing. Yeah we've had a few similar reports e.g. bug 2070375 and something clearly broke recently in how we manage sidebar state.
Updated•2 months ago
|
| Assignee | ||
Updated•2 months ago
|
| Assignee | ||
Comment 4•1 month ago
|
||
- Refactor sidebar visibility and sidebar state logic, removing multiple properties in browser-sidebar and sidebarState that handle launcher visibility
- Update test coverage, particularly for hide-sidebar setting
| Assignee | ||
Comment 5•1 month ago
|
||
What I think is happening with this bug, which impacts both "hide-sidebar" and "hide-on-close" settings, is that when you're on another sidebar setting initially, opening the settings panel will call show in browser-sidebar, but at that point the we assign _launcherStateAtOpen the value of this._state.launcherVisible which actually points to the previous visiblity settings value here.
And if you close a panel via the close button, hide is called - and dismissPanel called every time except with the hide-launcher setting here. Since this._state.launcherVisible = this._launcherStateAtOpen is assigned in that block it will assign the wrong value and it continues to be wrong every time we open a panel because there's a conflict in how this.launcherVisible is being set.
We also have a new launcherHiddenWithPanel which was added in bug 2047653 which is only being used for the new hide-launcher setting and that is intersecting with _launcherStateAtOpen and determining whether sidebarVisibility is reset in the panelOpen setter. It is essentially showing the launcher when a panel is opened for every sidebar visiblity setting except "hide-launcher" here which is not what we want.
Since the logic handling sidebar panel and launcher visibility has gotten more complex with the evolution of certain visibility behaviors (with bug 2007183) and the addition of a new one setting, "hide-launcher" in bug 2047653 I propose a refactor to simplify how different properties are set.
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
Updated•1 month ago
|
Comment 8•1 month ago
|
||
Backed out for causing failures at browser_ext_sidebarAction.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/e2e23db0785a
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=595578211&repo=autoland&task=B4yNdkLpSgSL6D4Xm6JnjA.0&lineNumber=2194
https://treeherder.mozilla.org/logviewer?job_id=595577785&repo=autoland&task=WKeCGhB-TzeV-LwniECmzw.0&lineNumber=32920
| Assignee | ||
Updated•1 month ago
|
Comment 10•1 month ago
|
||
Comment 11•1 month ago
|
||
Backed out for causing bc failures @ browser_remove_sidebar_button_and_sidebar.js
Comment 12•1 month ago
|
||
Comment 13•1 month ago
|
||
Comment 14•1 month ago
|
||
Backed out for causing failures at browser_extensions_sidebar.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/13c81ddd9c41
Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=HJ0as4ZYRyeX3w9Zzc2f6Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=0424d2f0cfd294609ca2741c9046afa46e3fc349
Comment 15•1 month ago
|
||
Comment 16•1 month ago
|
||
| bugherder | ||
Comment 17•1 month ago
|
||
Backout was merged into main: https://hg.mozilla.org/mozilla-central/rev/9f64bb532283aea6a40b4415131ac8e4a80e9a66
| Assignee | ||
Updated•1 month ago
|
Comment 18•1 month ago
|
||
Comment 19•1 month ago
|
||
Comment 20•1 month ago
|
||
Reverted this because it was causing mochitests failures in browser_opentabs_sidebar.js.
- Revert link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_opentabs_sidebar.js | test_opentabs_lists_current_window_tabs - Open tabs panel is shown. - false == true
| Assignee | ||
Comment 21•1 month ago
|
||
Sigh, I did not see this failure on the latest try push or locally.
Comment 22•1 month ago
|
||
Comment 23•1 month ago
|
||
| bugherder | ||
Updated•22 days ago
|
Description
•