2070673 - Enable PiP playback speed control

Status: RESOLVED FIXED

(Toolkit :: Picture-in-Picture, task)

Description

[kpatenio]

Once we've fixed bugs for the playback controls and polished up some visuals, we can flip the pref media.videocontrols.picture-in-picture.playback-speed.enabled to true and let it ride the trains. This ticket is a reminder to flip that pref once ready.

Comment 1

[Wellington Torrejais da Silva]

Hi,

After some tests:
Bug 2071996 - [PiP] Playback speed controls are hidden on default window sizes; should collapse into a popover/flyout menu

Thanks!

Comment 2

[kpatenio]

Attachment: Bug 2070673 - enable playback speed controls for PiP player. r=#pip-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7dba7828d76d
https://hg.mozilla.org/integration/autoland/rev/9a4dee2caedf
enable playback speed controls for PiP player. r=mconley

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9a4dee2caedf

Comment 5

[kpatenio]

Release Note Request (optional, but appreciated)
[Why is this notable]: Adds a new control to Firefox Desktop's video Picture-in-Picture player - one that allows users to change the video's playback speed, ranging from 0.25x speed to 2.0x speed.
[Affects Firefox for Android]: No
[Suggested wording]: Added a new playback speed setting to the Picture-in-Picture player, with options ranging from 0.25x to 2.0x speed. Please note that the setting is only visible on medium or larger player windows.
[Links (documentation, blog post, etc)]:

Comment 6

[Donal Meehan [:dmeehan]]

Added to the Fx160 nightly release notes, please allow 30 minutes for the site to update.