20714 - [DOGFOOD] build crashes in profile manager at launch

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, defect, P1)

Description

[cpratt]

Build ID: 1999120308
Platform: Linux

To reproduce:
- At the command prompt, type ./mozilla

Result: The application freezes. According to granrose, it quits on his machine.

Expected result: The app launches.

Workaround: ./mozilla -installer will allow you to launch the app.

Comment 1

[Jon Granrose]

when starting mozilla without a  ~/.mozilla directory, I get the following:

buell.mcom.com:208% ./mozilla
MOZILLA_FIVE_HOME=/u/granrose/communicator/linux/package

LD_LIBRARY_PATH=/u/granrose/communicator/linux/package/Cool:/u/granrose/communicator/linux/package:/usr/lib:/usr/openwin/lib
      XPCS_HOME=/u/granrose/communicator/linux/package/Cool
      MOZ_PROGRAM=./mozilla-bin
      MOZ_TOOLKIT=
        moz_debug=0
     moz_debugger=
nNCL: registering deferred (0)
got a request
buell.mcom.com:209%

It shows the "create new profile" window for about 3 seconds and then it
disappears.

Comment 2

[Joseph Elwell]

I wiped out my Users50 directory and restarted Mozilla. Mozilla (the browser)
always launches just fine. But if I click on the mail button on the bottom left
(or select Tasks - Mail), then it crashes. This was on WinNT Build 199120308.
This is clearly a regression.
My command line shows:
"nsXULKeyListenerImpl::Init()
attempt to UpgradePrefs. If that fails, open the account wizard."
Launching ./mozilla -installer didn't help. In fact, if I click on "New" in the
Profiles and Migration box: Mozilla crashes.

Comment 3

[Jon Granrose]

jelwell: that sounds like bug 20722.

Comment 4

[Jon Granrose]

now if I remove my .mozilla directory and run ./mozilla with the 1999120311
builds, it doesn't exit, but gives this error:

buell.mcom.com:120% ./mozilla
MOZILLA_FIVE_HOME=/u/granrose/communicator/linux/package

LD_LIBRARY_PATH=/u/granrose/communicator/linux/package/Cool:/u/granrose/communicator/linux/package:/usr/lib:/usr/openwin/lib:/builds/mozilla/dist/bin
      XPCS_HOME=/u/granrose/communicator/linux/package/Cool
      MOZ_PROGRAM=./mozilla-bin
      MOZ_TOOLKIT=
        moz_debug=0
     moz_debugger=
nNCL: registering deferred (0)
got a request
JavaScript Error: TypeError: contentWindow has no properties
URL: chrome://profile/content/createProfileWizard.js
LineNo: 166

and I get the following when I click any of the buttons in the create new
profile window:

JavaScript Error: TypeError: contentWindow has no properties
URL: chrome://profile/content/createProfileWizard.js
LineNo: 174

I have to close the window to get it to stop as cancel doesn't work.

Comment 5

[Chris McAfee]

This is holding the tree closed, marking so.
Assigning to racham.

Comment 6

[travis]

dom checkins should fix this.

Comment 7

[cpratt]

Using the 1999120311 (11:58 am) build on Linux, I no longer crash at startup.
Marking verified.

Comment 8

[racham]

Please use command line option mozilla -CreateProfile "profileName profileDir"
to create a profile and to proceed using browser while I investigate the
problem.

This got to be a new JS problem. Adding Brendan and Seth to the cc list as the
JS error coming the code they touched.

Comment 9

[Chris McAfee]

That is a Win32-only commandline, no?

Comment 10

[Jon Granrose]

this is a linux command line as well.

with the 11am builds with both travis' dom fixes, it does not exit, but still
gives an error if you have no ~/.mozilla directory and click on "Next" in the
create new profile window.  clicking cancel will close the window however.

Comment 11

[Jon Granrose]

this is what I got on my linux console when I start with no .mozilla and click
Next, then Cancel:

buell.mcom.com:33% ./mozilla
MOZILLA_FIVE_HOME=/u/granrose/communicator/linux/package
  LD_LIBRARY_PATH=/u/granrose/communicator/linux/package/Cool:/u/granrose/comm
unicator/linux/package:/usr/lib:/usr/openwin/lib:/builds/mozilla/dist/bin
      XPCS_HOME=/u/granrose/communicator/linux/package/Cool
      MOZ_PROGRAM=./mozilla-bin
      MOZ_TOOLKIT=
        moz_debug=0
     moz_debugger=
nNCL: registering deferred (0)
JavaScript Error: TypeError: contentWindow has no properties
URL: chrome://profile/content/createProfileWizard.js
LineNo: 166

JavaScript Error: TypeError: contentWindow has no properties
URL: chrome://profile/content/createProfileWizard.js
LineNo: 174

This could be symtomatic of a larger problem with javascript and/or buttons.

Comment 12

[Jon Granrose]

Not quite fixed on linux.  nuke ~/.mozilla, and get the following:

buell.mcom.com:51% ./mozilla
MOZILLA_FIVE_HOME=/u/granrose/communicator/linux/package

LD_LIBRARY_PATH=/u/granrose/communicator/linux/package/Cool:/u/granrose/communicator/linux/package:/usr/lib:/usr/openwin/lib:/builds/mozilla/dist/bin
      XPCS_HOME=/u/granrose/communicator/linux/package/Cool
      MOZ_PROGRAM=./mozilla-bin
      MOZ_TOOLKIT=
        moz_debug=0
     moz_debugger=
nNCL: registering deferred (0)
got a request
got a request
got a request
Error: Can't load:
file:////u/granrose/communicator/linux/package/chrome/profile/content/default/null.xul
(8052e891)
JavaScript Error: TypeError: contentWindow.GetFields is not a function
URL: chrome://profile/content/createProfileWizard.js
LineNo: 174

the first error is from hitting Next, the javascript error is from hitting
finish.

Comment 13

[Chris McAfee]

I have all of travis' changes, I cannot get through new profile
creation still. (Linux)

Comment 14

[edburns]

I'm experiencing this on winnt as well:

Opening file null.xul failed
Error: Can't load:
file:///E|/Projects/mozilla/dist/WIN32_D.OBJ/bin/chrome/profile/content/default/
null.xul (8052e891)

Comment 15

[edburns]

workaround:

<sleestack> edburns: mozilla -CreateProfile "profileName profileDir"

Comment 16

[Jon Granrose]

has anyone tried this with the updates to mozilla/rdf?  I just found out I
missed the updates travis did at 11:29 and didn't realize it until I pulled
waterson's recent checkin.

Comment 17

[Jon Granrose]

nevermind, I just got the latest linux builds, still broken.

Comment 18

[Chris Waterson]

I'm looking at this. It looks like there is an IFRAME that gets its src= URL
set to chrome://profile/content/null.xul (setting breakpoint in
nsWebShell::LoadURL got me that). Can't seem to figure out who's doing it.

Comment 19

[Chris Waterson]

Ok, it looks like what is happening is that wrong event handler is firing.
Instead of firing "onFinish()", it's firing "onNext()" when you press the
"Finish" button. sspitzer: any clue why this might be happening?

Comment 20

[Chris Waterson]

I bet what's broken is this:

http://lxr.mozilla.org/mozilla/source/profile/resources/content/createProfileWi
zard.js#119

The code that does a setAttribute() to change the event handler. Digging...

Comment 21

[Chris Waterson]

Okay, I think I know what the problem is. Brendan's change caches the compiled
script, and doesn't account for somebody changing the string value later. I'll
fix it.

Comment 22

[(not reading, please use [e-mail] instead)]

right, in createProfileWizard.js, we change the onclick handler dynamically.

line 119:
	nextButton.setAttribute("onclick","onFinish(opener)");

nice work, waterson.

Comment 23

[Chris Waterson]

fix checked in

Comment 24

[racham]

*** Bug 20820 has been marked as a duplicate of this bug. ***

Comment 25

[ckritzer (gone)]

Re-opening.

Okay.  Still crashes (or simply never never never loads) from the profile
manager in:
	- Linux6 1999120613 mozilla

But only if you have less than or more than 1 (one) profile and only after you
select the profile from the Profile Manager.  If you have only one profile,
force mozilla to load the Profile Manager (mozilla.exe -ProfileManager [windows]
or mozilla.sh -ProfileManager [linux]) and select the only profile, it will load
fine.

Also checked (and behaves correctly) on:
	- MacOS86 1999120608
	- WinNT 1999120608

Comment 26

[Chris Waterson]

I can reproduce the crash. Running in debugger just hangs. This is going to be
tough to figure out.

Comment 27

[Chris Waterson]

Attachment: proposed fix

Comment 28

[Chris Waterson]

Turns out that we had two JS Runtimes fighting each other for control of the
earth. That, plus a couple of rooting bugs made for some pretty cool sprinking
of 0x4 (the JS GC mark bit) throughout random memory.

Comment 29

[Brendan Eich [:brendan]]

Cc'ing alecf, cuz he volunteered to clean up (rewrite and make ownable)
componentized pref code.  Plus, I think he XPConnected the motherless old code
in the first place, which exposed objects from the secret "config" runtime to
the one true runtime.

/be

Comment 30

[Daniel Veditz [:dveditz]]

Sounds similar to dougt's 20964 -- wanna check Waterson's fix Doug?

Comment 31

[Chris Waterson]

Attachment: jsatom debugging code

Comment 32

[Alec Flett]

yup, that would have been me who both volunteered and did some damage a while
ago in the name of scripting prefs. :)
If waterson's fix fixes this bug, I'd rather have a fresh bug for cleanup of prefs.

Comment 33

[Brendan Eich [:brendan]]

Don't get me wrong: alecf, kudos to you for adding scriptability to prefs,
enabling the XUL/JS modern world that wouldn't exist without it -- kudos too for
offering to fix up prefs later.  The bug I just filed for that later cleanup is
bug 21135.

/be

Comment 34

[Chris Waterson]

*** Bug 20868 has been marked as a duplicate of this bug. ***

Comment 35

[cpratt]

Haven't seen this happening in some time... Verified using the 1999121308 build,
Linux.

Comment 36

[leger]

Moving all Profile Manager bugs to new Profile Manager Backend component.
Profile Manager component to be deleted.