2076335 - Printing multiple messages happens even if you cancel the print dialog

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

Select two messages, go to File > Print, cancel. Two messages are printed.

From about3Pane.js:

Cc["@mozilla.org/widget/printdialog-service;1"]
  .getService(Ci.nsIPrintDialogService)
  .showPrintDialog(window, false, ps);
if (ps.isCancelled) {
  return;
}

showPrintDialog is now async (bug 2035195), and we are not awaiting it, so we don't get the NS_ERROR_ABORT it throws, and isCancelled disappeared four years ago (bug 1766651).

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 2076335 - Await showPrintDialog when printing multiple messages. r=#thunderbird-reviewers

Comment 2

[Wayne Mery (:wsmwk)]

Does the same thing happen for you with print to pdf? Cancel print to pdf is WFM on mac daily. Ditto for contacts, which is Bug 1336368 - Clicking "Cancel" on "Print Contacts" dialog prints contacts nevertheless

There is also a very old Bug 87474 - Only first print job is prompted for print or cancel

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f6e29f2f3923
Await showPrintDialog when printing multiple messages. r=mkmelin