Closed Bug 2077969 Opened 10 days ago Closed 1 day ago

Several dialogs have transparent backgrounds

Categories

(Thunderbird :: Theme, defect)

Thunderbird 157
x86_64
All
defect

Tracking

(thunderbird_esr153 unaffected, thunderbird158 affected, thunderbird159 affected)

RESOLVED FIXED
160 Branch
Tracking Status
thunderbird_esr153 --- unaffected
thunderbird158 --- affected
thunderbird159 --- affected

People

(Reporter: douger34, Assigned: mkmelin)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [theme: Solarized light ternoc Theme])

Attachments

(3 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:157.0) Gecko/20100101 Firefox/157.0

Steps to reproduce

Clicked on Message Filters and ...Key Manager

Actual results

The dialog comes with with a transparent background.

Expected results

Background should be, and used to be, opaque.

Another example.

I didn't go thru all the dialogs to see which other ones might also be broken, but since I found two I suspect there might be others.

MacOS 11.7.11

OS: Unspecified → macOS
Hardware: Unspecified → x86_64

The Check Spelling dialog also has a transparent background.

I checked this issue on macOS Sequoia 15.4.7 and macOS Tahoe 26.7, and was not able to reproduce it on either.

I first tested starting on Thunderbird 156.0 and updated the same profile step by step up to 157.0.1, checking at each point along the way, and did not see the transparent background at any stage. I also separately downloaded 157.0 and tried to reproduce this using a completely fresh profile, and still could not reproduce the issue.

I tried different themes (light, dark, and system default) and the Message Filters dialog background was consistently opaque in all cases. Checked the OpenPGP Key Manager, and Check Spelling dialogs as well as other dialogs Certificate Manager, Advance Account Settings and they all are opaque.

Can you please tell us which Thunderbird theme are you using (light, dark, system, or a custom/alternative theme) and does it still happens in Troubleshoot mode?

Theme: "Thunderbird" "Light".

In Troubleshoot Mode the problem goes away. The only add-on I have is a DKM checker that is disabled because it no longer works properly. I can remove it and see what happens.

Oops. Theme is actually "Solarized light ternoc Theme".

Yup, that Theme is the problem. I'll see if I can contact the author.

Should I resolve the problem? What status do I use? INVALID?

No way to contact author directly so I wrote a review with description of problem.

Status: UNCONFIRMED → RESOLVED
Closed: 7 days ago
Resolution: --- → INVALID

Actually this is a problem with several themes (a lot?)

Some of the more popular themes showing it:
https://addons.thunderbird.net/nl/thunderbird/addon/nu-grey-theme/?src=cb-dl-users (1808 users)
https://addons.thunderbird.net/nl/thunderbird/addon/muted-sage-gruvbox-dark/?src=cb-dl-users (1639 users)
https://addons.thunderbird.net/nl/thunderbird/addon/dracula-theme-for-thunderbird/?src=cb-dl-users (1551 users)

These themes do not use a background image, they only set colors.

Apparently there is no default background color set any more for body, only for body.someclass.

I don't know when exactly this started, 153 esr is not affected.

Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: INVALID → ---
Component: Untriaged → Theme
OS: macOS → All

Not a bug in core. You'd have to contact the authors to update.

Status: REOPENED → RESOLVED
Closed: 7 days ago → 2 days ago
Resolution: --- → INVALID
Whiteboard: [theme: Solarized light ternoc Theme]

This affects all themes, some theme colors can not be set correctly any more.
"frame" now shows transparent on Linux/macOS and the accentcolor on Windows.
"frame_inactive" shows transparent on Linux/macOS and Windows.

Since most themes set only a background image (no colors) most users won't even notice.

A change in core that affects all themes is a bug in core, not a bug in those themes.

Reopening for investigation

Status: RESOLVED → REOPENED
Resolution: INVALID → ---

Regressed by bug 1742162. The toolkit patch (bug 1742111) was backed-out but our patch not.

Can https://hg.mozilla.org/comm-central/rev/2fa4f9264c1b backed-out?

Flags: needinfo?(mkmelin+mozilla)
Regressed by: 1742162

Sure, for process it's probably easiest to send a revert req through phab. I'll do that in a minute.

Flags: needinfo?(mkmelin+mozilla)
Assignee: nobody → mkmelin+mozilla
Target Milestone: --- → 160 Branch

Pushed by vineet@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/b5ed4004840a
Revert changeset 186cb4456a19 (bug 1742162) as m-c backed out. r=Paenglab

Status: REOPENED → RESOLVED
Closed: 2 days ago → 1 day ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: