Closed Bug 2079024 Opened 1 month ago Closed 1 month ago

[gv-junit] Re-enable geckoview-junit tests that no longer need their fission skip

Categories

(GeckoView :: General, task)

All
Android
task
Points:
3

Tracking

(firefox160 fixed)

RESOLVED FIXED
160 Branch
Tracking Status
firefox160 --- fixed

People

(Reporter: owlish, Assigned: owlish)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fxdroid][group6])

Attachments

(1 external file)

Three geckoview-junit tests carry an assumeThat(sessionRule.env.isFission, ...) guard that skips them when fission is enabled. All three now pass under fission, so the guards can go:

  • GeckoSessionTestRuleTest.waitForPageStops_acrossSessionCreation, skipped for bug 1673953
  • ScreenshotTest.capturePixelsWhileSessionDeactivated, skipped for bug 1837551
  • NavigationDelegateTest.bypassHTTPSOnlyError, skipped for bug 1849060 (fission plus debug only)

Verified on a try push with the guards removed, running every geckoview-junit task with 10 retriggers each (opt, debug, debug-isolated-process and lite/opt, in both the geckoview-fission and no-fission variants). None of the three failed in any run.

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=500a99553f6b6b285db7ae3cb3fafddb58eccaa8

GeckoSessionTestRuleTest.createOpenSession_canInterleaveOtherCalls keeps its guard. It is the other test disabled by bug 1673953, and it still fails under fission in 26 of 40 runs with UiThreadUtils$TimeoutException: Timed out after 30000ms.

FissionTest.fissionDisabledByEnvironment also keeps its guard, which is a precondition rather than a disable: the test asserts that fission is not running. The test will be removed when the non-fis gv-junit variant is removed.

See Also: → 1673953
Assignee: nobody → bugzeeeeee
Status: NEW → ASSIGNED
Assignee: bugzeeeeee → nobody
Blocks: 1673729
Status: ASSIGNED → NEW
Severity: -- → N/A
Assignee: nobody → bugzeeeeee
Pushed by istorozhko@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/473a2c3688cd https://hg.mozilla.org/integration/autoland/rev/6d797afa2401 Re-enable geckoview-junit tests that no longer need their fission skip r=geckoview-reviewers,ohall
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3d880c8a4e20 https://hg.mozilla.org/integration/autoland/rev/379c53c05f2d Revert "Bug 2079024 - Re-enable geckoview-junit tests that no longer need their fission skip r=geckoview-reviewers,ohall" for causing gv-junit failures.
Pushed by csabou@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/aa9fc669aa99 https://hg.mozilla.org/mozilla-central/rev/d5958157493a Revert "Bug 2079024 - Re-enable geckoview-junit tests that no longer need their fission skip r=geckoview-reviewers,ohall" for causing gv-junit failures.

Backed out for causing gv-junit failures.

Flags: needinfo?(bugzeeeeee)
Depends on: 1673953
No longer depends on: 1673953
Flags: needinfo?(bugzeeeeee)

We still have one actual failure there, potentially a platform bug - Bug 1673953. It needs to be investigated. I will leave that test disabled for now.

Attachment #9654672 - Attachment description: Bug 2079024 - Re-enable geckoview-junit tests that no longer need their fission skip → Bug 2079024 - Re-enable geckoview-junit tests that no longer need their fission skip r=geckoview-reviewers,ohall
Whiteboard: [fxdroid][group6]
Blocks: 2068254
Summary: Re-enable geckoview-junit tests that no longer need their fission skip → [gv-junit] Re-enable geckoview-junit tests that no longer need their fission skip
Points: --- → 3
Pushed by istorozhko@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/90303d48d601 https://hg.mozilla.org/integration/autoland/rev/5bd6d60b2834 Re-enable geckoview-junit tests that no longer need their fission skip r=geckoview-reviewers,ohall

The GeckoSessionTestRuleTest.waitForPageStops_acrossSessionCreation still stays skipped, as the issue still there - I reopened the bug. However, found another test in NavigationDelegateTest that had a non-fission branch - deleting that one.

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: