[gv-junit] Re-enable geckoview-junit tests that no longer need their fission skip
Categories
(GeckoView :: General, task)
Tracking
(firefox160 fixed)
| Tracking | Status | |
|---|---|---|
| firefox160 | --- | fixed |
People
(Reporter: owlish, Assigned: owlish)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [fxdroid][group6])
Attachments
(1 external file)
Three geckoview-junit tests carry an assumeThat(sessionRule.env.isFission, ...) guard that skips them when fission is enabled. All three now pass under fission, so the guards can go:
GeckoSessionTestRuleTest.waitForPageStops_acrossSessionCreation, skipped for bug 1673953ScreenshotTest.capturePixelsWhileSessionDeactivated, skipped for bug 1837551NavigationDelegateTest.bypassHTTPSOnlyError, skipped for bug 1849060 (fission plus debug only)
Verified on a try push with the guards removed, running every geckoview-junit task with 10 retriggers each (opt, debug, debug-isolated-process and lite/opt, in both the geckoview-fission and no-fission variants). None of the three failed in any run.
Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=500a99553f6b6b285db7ae3cb3fafddb58eccaa8
GeckoSessionTestRuleTest.createOpenSession_canInterleaveOtherCalls keeps its guard. It is the other test disabled by bug 1673953, and it still fails under fission in 26 of 40 runs with UiThreadUtils$TimeoutException: Timed out after 30000ms.
FissionTest.fissionDisabledByEnvironment also keeps its guard, which is a precondition rather than a disable: the test asserts that fission is not running. The test will be removed when the non-fis gv-junit variant is removed.
| Assignee | ||
Comment 1•1 month ago
|
||
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 6•1 month ago
|
||
We still have one actual failure there, potentially a platform bug - Bug 1673953. It needs to be investigated. I will leave that test disabled for now.
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Updated•1 month ago
|
| Assignee | ||
Comment 8•1 month ago
|
||
The GeckoSessionTestRuleTest.waitForPageStops_acrossSessionCreation still stays skipped, as the issue still there - I reopened the bug. However, found another test in NavigationDelegateTest that had a non-fission branch - deleting that one.
Description
•