Use the ghost button disabled text color for toolbar buttons outside forced-colors media queries
Categories
(Toolkit :: Themes, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox161 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
Attachments
(1 external file)
Bug 2074906 set color: var(--button-text-color-disabled) on disabled toolbar buttons inside @media (forced-colors) in toolbarbutton-icons.css, arrowscrollbox.css and the Windows organizer.css. After bug 2084519, toolbarbutton.css gives disabled toolbarbuttons --button-text-color-ghost-disabled, which inherits by default and is GrayText under forced colors.
organizer.css can drop its block, since nothing overrides that rule there. In toolbarbutton-icons.css and arrowscrollbox.css, a color: inherit rule outranks it, so those sheets can set color: var(--button-text-color-ghost-disabled) on [disabled] unconditionally instead.
| Assignee | ||
Comment 1•1 month ago
|
||
The fill rules stay in @media (forced-colors): --toolbarbutton-icon-fill-disabled is computed at :root, so outside forced colors it would miss the Windows body override of --toolbarbutton-icon-fill in an accent-colored titlebar.
The color rules can't simply go, because color: inherit on .toolbarbutton-1 and on the arrowscrollbox's toolbarbutton outranks toolbarbutton.css's :where([disabled]) rule; nothing overrides it in organizer.css, so that block goes.
No visible change in the default, in-app, forced-colors and native prefers-contrast themes. Under prefers-contrast with the in-app theme, disabled labels go from rgb(21, 20, 26) to rgb(22, 20, 35).
Updated•1 month ago
|
Comment 3•28 days ago
|
||
| bugherder | ||
Updated•11 days ago
|
Description
•