Closed Bug 209355 Opened 21 years ago Closed 18 years ago

Bookmark Manager: remove "Sort Folder By Name" (Ctrl-N) shortcut, or add a warning dialog

Categories

(SeaMonkey :: Bookmarks & History, defect)

defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey1.1alpha

People

(Reporter: jjlin, Assigned: sgautherie)

References

Details

(Keywords: dataloss, fixed-seamonkey1.1a, Whiteboard: [verified-seamonkey1.0.3 verified-seamonkey1.1a])

Attachments

(1 obsolete file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030529
Build Identifier: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.4) Gecko/20030529

This is related to bug 209198, but not quite the same thing. Pressing Ctrl-N
while in the bookmark manager is easy to do inadvertently, and it permanently
sorts bookmarks by name. This feature is also not present in 1.3, which causes
still greater confusion for those not familiar with 1.4 quirks.

Reproducible: Always

Steps to Reproduce:
1. Open bookmark manager, e.g. with Ctrl-B.
2. Press Ctrl-N in bookmark manager.

Actual Results:  
Bookmarks are immediately sorted by name and generally cannot be restored to
their previous, possibly unsorted, order.

Expected Results:  
There should be a warning dialog that explains that the change is permanent
(like what happens if you click the column header). There should also be a
checkbox to suppress this warning in the future.
Severity: critical → major
Bug Day: 1-13-2004
Tested With: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7a) Gecko/20040113

While this may be not the desired behavior, it's not a bug.  To add this
functionality would be an "enhancement" please change the bug type appropriately.
I disagree. At least on 1.4, Ctrl-N opens a new navigator window in Navigator,
Composer, Messenger, and Address Book, and it does nothing in History. On the
other hand, it potentially destroys your bookmarks (i.e., dataloss) in Bookmark
Manager, without any warning whatsoever. While I wouldn't say the following is
true in general, in this case, if this isn't a feature, it's a bug.
I'll second to claim this to be a bug.

I suffered data loss with it.  To me, the damage is pretty too bad for a 
consequence of single shortcut key, which usually has no harm in other situations 
(inside/outside Mozilla).

/* BTW: what I expect is rather `New Bookmark...' function, not `Sort Folder by 
   Name...', for the key assignment of Ctrl-N in Bookmark Manager. (of course this
   is just another suggestion for enhancement) */
why is Ctrl+N shortcut not shown on any menu item?
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** Bug 232988 has been marked as a duplicate of this bug. ***
Daniel: the shortcut appears for me on Edit -> Sort Folder by Name.
OS: Linux → All
(In reply to comment #3)
> I'll second to claim this to be a bug.
> []

I'll third this as a bug.  I also lost data, was very lucky I was in a low-level
sub-folder or it would have created a major mess.  Only because of the overall
extreme slop of bookmarks behavior at present, I've been backing up with extreme
paranoia.  That backing up kept this from being very severe.  IMO, it also is a
*bug* because this behavior differs from NS 4.x and early versions of Moz. 
Frankly, I cannot fathom why this ever got implemented.  These bookmarks
problems *really* need to get sorted out before 1.7-final goes, if that is to be
claimed as a 'major' version.  I am glad to see it apparently has not been
forced out prematurely yet, but I am concerned the latest announcement marks the
1.7rc3 as the 'intended ... final release candidate'.  *Please* try to ensure
the bookmarks are behaving stably and consistently before the final 1.7!  Thanks. 

Flags: blocking1.7?
(In reply to comment #0)

> Reproducible: Always

I did not try :->

> Expected Results:  
> There should be a warning dialog that explains that the change is permanent
> (like what happens if you click the column header). There should also be a
> checkbox to suppress this warning in the future.

The "column header" code was changed by bug 221619 attachment 140664 [details] [diff] [review] (for
Mv1.8a1, I think):
{{
varga%nixcorp.com	2004-04-16 22:53	 	Fix for bug 221619. Tree widget refactoring
and enhancement. r=neil sr=bryner
}}

Brian, Neil:
Should bug 221619 fix(es) land on v1.7 branch too ?
or should something like
{{
-            var promptService =
Components.classes["@mozilla.org/embedcomp/prompt-service;1"]
-                               
.getService(Components.interfaces.nsIPromptService);
-            var title = BookmarksUtils.getLocaleString("confirm_sorting_title");
-            var message =
BookmarksUtils.getLocaleString("confirm_sorting_message");
-            var checkMessage =
BookmarksUtils.getLocaleString("confirm_sorting_check_message");
-            var checkValue = {};
-            confirmed = promptService.confirmCheck(window, title, message,
-                                                   checkMessage, checkValue);
}}
be added for the current bug on the v1.7 branch only !?
Any other suggestion ?

Anybody tried v1.8a1 yet ? What is its behaviour in these cases ??
(from a very quick look at the mentionned patch, I guess it sorts the _view_ and
add an option to _restore_ the "natural order" !!?)
Jan, restoring the confirmation prompt but for ^N sounds good to me.
Assignee: p_ch → varga
Flags: blocking1.7? → blocking1.7-
OK, if you all are going to refuse blocking 1.7 on these very sloppy bookmarks issues, I sure as hell hope you are not continuing to tout that as some major milestone!  This and the bookmarks-saving problem [bug 203343] are so critical that if you do not fix them for 1.7 final, everyone should take severe issue with any claims that 1.7 is the 'most stable yet', etc.!  Repeating my block request; please take this *seriously*.  
Flags: blocking1.7- → blocking1.7+
No. No way. This is not a blocker. Please do not set the plus status on any
flags. That status belongs to a select few. Thanks.
Flags: blocking1.7+ → blocking1.7-
"Sort Folder By Name" should be added to the summary of this bug report, as that
is what the command is called in Bookmark Manager's interface
Summary: Ctrl-N to sort bookmarks by name should give warning dialog → Ctrl-N to sort bookmarks folder by name should give warning dialog
I disagree, you should have assigned some other key-combo to this function.
Product: Browser → Seamonkey
*** Bug 248913 has been marked as a duplicate of this bug. ***
I encountered this bug the 5th time now (in Seamonkey). I encountered 3 data losses due to that bug. (The other times I actually noticed that bookmarks were damaged and thus immediately made an emergency backup copy of "bookmarks.html".)

Sorting bookmarks should not have a shouldcut at all (and if it was to have a shortcut, it should require a confirmation dialog and the shortcut should not be "Ctrl+N", which is mapped to "New Navigator Window" both within Navigator, Messenger, Composer as well as Address Book windows).

The shortcut "Ctrl+N" should be consistently mapped to "New Navigator Window" in every Mozilla Seamonkey window (Navigator, Messenger, Composer, Bookmarks, Address Book, ChatZilla). Inconsistent shortcut mapping is bad user interface design.

Inadvertedly and unintendedly damaging data (particular bookmark sort order) without "undo" is a critical bug.


request remove the shortcut for the following reasons:
* ctrl-N is used in *every* component of the suite to create a new browser window...except in bookmarks. ctrl-N in bookmarks is a *major* and unneccessary inconsistency in the IU
* dataloss issue, insofar as it trashes bookmark order with no ability to undo (other than revert to a backup)
* easily available via "alt-E, N".
* a trivial patch compared to a warning dialogue

Not in favor a waiting for the new places component (bookmarks+history), if it comes to Seamonkey, to eliminate the need for this change.

modifying summary with the reporter's permission - "I do think your solution is quite acceptable too (actually, I like it even better than the warning dialog)."

I'll be voting for this bug :)
Assignee: Jan.Varga → nobody
Severity: major → critical
Flags: blocking-seamonkey1.1a?
Keywords: dataloss
QA Contact: chrispetersen → bookmarks
Hardware: PC → All
Summary: Ctrl-N to sort bookmarks folder by name should give warning dialog → bookmarks remove shortcut Ctrl-N "Sort Folder By Name" or give give warning dialog
(In reply to comment #8)
> (In reply to comment #0)
> 
> > Reproducible: Always
> 
> I did not try :->
> 
> (from a very quick look at the mentionned patch, I guess it sorts the _view_ and
> add an option to _restore_ the "natural order" !!?)

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20060402 SeaMonkey/1.5a] (nightly) (W98SE)

I guessed wrong :-(

Taking bug.
Assignee: nobody → gautheri
Summary: bookmarks remove shortcut Ctrl-N "Sort Folder By Name" or give give warning dialog → Bookmark Manager: remove "Sort Folder By Name" (Ctrl-N) shortcut, or add a warning dialog
Target Milestone: --- → seamonkey1.5alpha
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.9a1) Gecko/20060402 SeaMonkey/1.5a] (nightly) (W98SE)

Tested fine.
Attachment #217152 - Flags: superreview?(neil)
Attachment #217152 - Flags: review?(neil)
Status: NEW → ASSIGNED
Attachment #217152 - Flags: superreview?(neil)
Attachment #217152 - Flags: superreview+
Attachment #217152 - Flags: review?(neil)
Attachment #217152 - Flags: review+
Comment on attachment 217152 [details] [diff] [review]
(Av1) <bookmarks*.*> KeyBinding removal
[Checked in: Comment 20 & 29]

'approval&#8209;seamonkey1.*=?': (SeaMonkey only)
Trivial U.I. fix, no risk.
(if not too late)
Attachment #217152 - Flags: approval-seamonkey1.1a?
Attachment #217152 - Flags: approval-seamonkey1.0.2?
Attachment #217152 - Flags: approval-seamonkey1.1a? → approval-seamonkey1.1a+
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: blocking-seamonkey1.1a?
Resolution: --- → FIXED
Comment on attachment 217152 [details] [diff] [review]
(Av1) <bookmarks*.*> KeyBinding removal
[Checked in: Comment 20 & 29]


Checkin: { 2006-04-04 14:00	neil%parkwaycc.co.uk }
Attachment #217152 - Attachment description: (Av1) <bookmarks*.*> KeyBinding removal → (Av1) <bookmarks*.*> KeyBinding removal [Checked in: Comment 20]
Attachment #217152 - Flags: approval-seamonkey1.0.2? → approval-seamonkey1.0.1?
Comment on attachment 217152 [details] [diff] [review]
(Av1) <bookmarks*.*> KeyBinding removal
[Checked in: Comment 20 & 29]

Too late for 1.0.1
Attachment #217152 - Flags: approval-seamonkey1.0.1? → approval-seamonkey1.0.1-
Attachment #217152 - Flags: approval-seamonkey1.0.2?
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20060406 SeaMonkey/1.1a] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH.
Whiteboard: [verified-seamonkey1.1a]
Target Milestone: seamonkey1.5alpha → seamonkey1.1alpha
Comment on attachment 217152 [details] [diff] [review]
(Av1) <bookmarks*.*> KeyBinding removal
[Checked in: Comment 20 & 29]

Note for the 1.8.0 branch:
The xul file could be updated alone, without changing the dtd file, if prefered !?
Comment on attachment 217152 [details] [diff] [review]
(Av1) <bookmarks*.*> KeyBinding removal
[Checked in: Comment 20 & 29]

The tree is already frozen for Gecko 1.8.0.4 / SeaMonkey 1.0.2, and this is not critical, so it can't make it any more.
Re-nominate for 1.0.3 if it's still wanted (and once the flag for it exists), please.
Attachment #217152 - Flags: approval-seamonkey1.0.2? → approval-seamonkey1.0.2-
(In reply to comment #24)
> (From update of attachment 217152 [details] [diff] [review] [edit])
> The tree is already frozen for Gecko 1.8.0.4 / SeaMonkey 1.0.2, and this is not
> critical, so it can't make it any more.
> Re-nominate for 1.0.3 if it's still wanted (and once the flag for it exists),
> please.
> 


'Not critical'???? How the hell do you figure that?????  It torches your bookmark-sorting order, which you may have been tending carefully for years, with no option of recovery, using a keystroke combination that behaves differently from any other moz window!  'Not critical'???? BS!!!!!!!!!  Not to mention the damn bug has been around THREE YEARS!!!  Geez; I'm just glad I keep backups of my bookmark file.  

Comment on attachment 217152 [details] [diff] [review]
(Av1) <bookmarks*.*> KeyBinding removal
[Checked in: Comment 20 & 29]

'approval-seamonkey1.0.3':
Missed 1.0.1 and 1.0.2 ... Retrying.
Attachment #217152 - Flags: approval-seamonkey1.0.3?
Comment on attachment 217152 [details] [diff] [review]
(Av1) <bookmarks*.*> KeyBinding removal
[Checked in: Comment 20 & 29]

a=me for SM1.0.3 (first one, another needed)
Attachment #217152 - Flags: approval-seamonkey1.0.3? → approval-seamonkey1.0.3+
Comment on attachment 217152 [details] [diff] [review]
(Av1) <bookmarks*.*> KeyBinding removal
[Checked in: Comment 20 & 29]

>Index: mozilla/xpfe/components/bookmarks/resources/locale/en-US/bookmarks.dtd
>===================================================================

Whoever will do the checkin: Please leave out this DTD portion of the patch and only check in the XUL change on 1.8.0 branch, as we don't want to have L10n files changing on a security/stable branch.
It does no harm to have an unused entity there for that branch, the XUL change alone fixes the bug pretty well.
Whiteboard: [verified-seamonkey1.1a] → [fixed-seamonkey1.0.3 verified-seamonkey1.1a]
I landed the XUL part on the 1.8.0 branch and left out l10n change
Flags: blocking1.7.14?
Whiteboard: [fixed-seamonkey1.0.3 verified-seamonkey1.1a] → [verified-seamonkey1.1a] fixed-seamonkey1.0.3
Comment on attachment 217152 [details] [diff] [review]
(Av1) <bookmarks*.*> KeyBinding removal
[Checked in: Comment 20 & 29]


Checkin: {
2006-07-04 11:16	ajschult%verizon.net 	mozilla/xpfe/components/bookmarks/resources/bookmarksManager.xul 	1.9.12.1 	MOZILLA_1_8_0_BRANCH
}
Attachment #217152 - Attachment description: (Av1) <bookmarks*.*> KeyBinding removal [Checked in: Comment 20] → (Av1) <bookmarks*.*> KeyBinding removal [Checked in: Comment 20 & 29]
Attachment #217152 - Attachment is obsolete: true
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.0.5) Gecko/20060705 SeaMonkey/1.0.3] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_0_BRANCH.
Whiteboard: [verified-seamonkey1.1a] fixed-seamonkey1.0.3 → [verified-seamonkey1.0.3 verified-seamonkey1.1a]
Flags: blocking1.7.14?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: