Closed
Bug 2094940
Opened 2 days ago
Closed 1 day ago
Remove the unused `MenuPresenter` from Fenix
Categories
(Firefox for Android :: Toolbar, task, P3)
Tracking
()
RESOLVED
FIXED
163 Branch
| Tracking | Status | |
|---|---|---|
| firefox163 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid] [group5])
Attachments
(1 external file)
MenuPresenter in mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ has no production callers. Its only remaining reference is MenuPresenterTest.
Its last consumer was the abstract ToolbarIntegration class, which created it next to ToolbarPresenter and ToolbarBehaviorController for the XML BrowserToolbar. Bug 2029550 Part 1 ("Remove xml toolbar support from browser screen") deleted ToolbarIntegration.kt but left MenuPresenter and its test in place.
MenuPresenter only calls BrowserToolbar.invalidateActions() and BrowserToolbar.onStop() on the legacy View toolbar, so the Compose toolbar has no use for it.
Steps:
- Delete
MenuPresenter.kt - Delete
MenuPresenterTest.kt - Remove any leftover detekt baseline entries that refer to them
Updated•2 days ago
|
| Assignee | ||
Comment 1•2 days ago
|
||
- Delete
MenuPresenterand `MenuPresenterTest that has been left behind since the XML toolbar removal in Bug 2029550
Updated•2 days ago
|
Attachment #9686078 -
Attachment description: Bug 2094940 - Remove the unused `MenuPresenter` from Fenix. → Bug 2094940 - Remove the unused `MenuPresenter` from Fenix
Pushed by gluong@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/1d40cfae871a
https://hg.mozilla.org/integration/autoland/rev/311c7ae19213
Remove the unused `MenuPresenter` from Fenix r=android-reviewers,petru
Comment 3•1 day ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 day ago
status-firefox163:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 163 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•