Closed Bug 2094940 Opened 2 days ago Closed 1 day ago

Remove the unused `MenuPresenter` from Fenix

Categories

(Firefox for Android :: Toolbar, task, P3)

All
Android
task

Tracking

()

RESOLVED FIXED
163 Branch
Tracking Status
firefox163 --- fixed

People

(Reporter: gl, Assigned: gl)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid] [group5])

Attachments

(1 external file)

MenuPresenter in mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ has no production callers. Its only remaining reference is MenuPresenterTest.

Its last consumer was the abstract ToolbarIntegration class, which created it next to ToolbarPresenter and ToolbarBehaviorController for the XML BrowserToolbar. Bug 2029550 Part 1 ("Remove xml toolbar support from browser screen") deleted ToolbarIntegration.kt but left MenuPresenter and its test in place.

MenuPresenter only calls BrowserToolbar.invalidateActions() and BrowserToolbar.onStop() on the legacy View toolbar, so the Compose toolbar has no use for it.

Steps:

  • Delete MenuPresenter.kt
  • Delete MenuPresenterTest.kt
  • Remove any leftover detekt baseline entries that refer to them
See Also: → 2094946
  • Delete MenuPresenter and `MenuPresenterTest that has been left behind since the XML toolbar removal in Bug 2029550
Attachment #9686078 - Attachment description: Bug 2094940 - Remove the unused `MenuPresenter` from Fenix. → Bug 2094940 - Remove the unused `MenuPresenter` from Fenix
See Also: → 2094955
See Also: → 2094991
Status: ASSIGNED → RESOLVED
Closed: 1 day ago
Resolution: --- → FIXED
Target Milestone: --- → 163 Branch
See Also: → 2095847
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: