Open Bug 2095060 Opened 2 days ago Updated 1 day ago

HDR video on YouTube rendered washed out / grey (PQ shown as SDR) on Windows, works in Edge

Categories

(Core :: Graphics: Color Management, defect)

Firefox 160
Desktop
Windows 11
defect

Tracking

()

UNCONFIRMED

People

(Reporter: laurent.h, Unassigned, NeedInfo)

References

Details

Attachments

(4 files)

Steps to reproduce

Environment:

  • Firefox 160 (release), Windows 11
  • Desktop PC, GPU: gtx 1070 / driver game ready 582.53
  • Display: Gigabyte G32QC, connected via displayport
  • Windows HDR ("Use HDR") is enabled for this display
  • Hardware acceleration enabled, WebRender (not software)

Steps:

  1. Enable HDR in Windows Settings > System > Display > HDR.
  2. Open an HDR video on YouTube in Firefox: https://www.youtube.com/watch?v=yTHEranHVoo
  3. Pick an HDR quality in the YouTube quality menu

Actual results

The video plays, but looks washed out and greyish, as if the BT.2100 PQ (HDR10) stream were displayed as BT.709 / SDR. No HDR highlights.
I join the screenshot but for un unknow reason, the capture for edge added brightness that is is not display usualy.

The same video on the same machine and display looks correct in Microsoft Edge.

Expected results

HDR video rendered correctly in HDR (bright highlights, correct contrast and colors), as in Microsoft Edge on the same setup.

OS: Unspecified → Windows 11
Hardware: Unspecified → Desktop

I forgot to mention that the HDR goes on for 1/4 of a second if the video is embbeded and go for fullscreen.

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: Color Management' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Graphics: Color Management
Product: Firefox → Core
See Also: → 2091358
See Also: → 2079476

Thanks for the report. On Windows, HDR video only shows correctly when Firefox can put the video in its own overlay layer. When the video gets drawn into the page instead, PQ video looks washed out and grey like in your screenshot. The brief flash of HDR when you go fullscreen suggests the overlay starts out working and then gets turned off.

A few things that would help:

  1. Could you try Firefox Beta (161) and Nightly (162)? Each one fixes something in this area: 161 fixes a case where some page effects stopped the video from getting its own layer, and 162 fixes some problems with how the video layer gets set up. Both install alongside release and use their own profiles.
    https://www.mozilla.org/firefox/channel/desktop/
  2. In release, play the HDR video until it looks wrong (try fullscreen too), then go to about:support, click "Copy text to clipboard", save it as a .txt file and attach it here with "Attach New File". The "Failure Log" section is the part we need most, so please copy it after you have reproduced the problem.
  3. In fullscreen, does it still look washed out after the YouTube controls fade away, if you keep the mouse still for a few seconds?
Flags: needinfo?(laurent.h)

Hi !

  1. I tried both version 161 and 162, still the same issue
  2. There is no failure in the log even when i reproduced the problem. Here are the log anyway
  3. Yes it's still washed out even when teh controls fade away

I attached the firefox log, and the youtube log from edge and from firefox, maybe a clue inside

Flags: needinfo?(laurent.h)
Attached file about:support —
Attached file debug_youtube_edge.txt —

Thanks, the about:support explains it. On GTX 10xx (Pascal) GPUs, Firefox turns off the compositor mode that video overlays need (WEBRENDER_COMPOSITOR is blocklisted because of bug 1923697, where video froze after switching windows). Without an overlay, Firefox draws HDR video into the page, and the page can't show HDR yet, so PQ video comes out washed out. That's bug 1765362.

To confirm this is the cause: in about:config, set gfx.webrender.compositor.force-enabled to true, restart Firefox, and play the same video. Does it show in HDR? Please set the pref back to false afterwards. The block exists because of the bug above, so video may freeze after you switch windows while the pref is on. If you do see that, please mention it.

See Also: → 1923697
See Also: → 1765362

Sotaro, the reporter has a GTX 1070, so WEBRENDER_COMPOSITOR is blocklisted for them by the NvidiaPascal entry from bug 1923697. That means there are no video overlays, and HDR video always looks washed out on their HDR monitor while Edge shows it correctly. The block applies to all driver versions and hasn't changed since 2024, apart from bug 1969255 changing Windows10 to Windows10or11. Is it still needed with current NVIDIA drivers (the reporter is on 582.53), or could it be limited to older drivers so Pascal users can get HDR video?

Flags: needinfo?(sotaro.ikeda.g)

(In reply to Timothy Nikkel (:tnikkel) from comment #8)

Thanks, the about:support explains it. On GTX 10xx (Pascal) GPUs, Firefox turns off the compositor mode that video overlays need (WEBRENDER_COMPOSITOR is blocklisted because of bug 1923697, where video froze after switching windows). Without an overlay, Firefox draws HDR video into the page, and the page can't show HDR yet, so PQ video comes out washed out. That's bug 1765362.

To confirm this is the cause: in about:config, set gfx.webrender.compositor.force-enabled to true, restart Firefox, and play the same video. Does it show in HDR? Please set the pref back to false afterwards. The block exists because of the bug above, so video may freeze after you switch windows while the pref is on. If you do see that, please mention it.

Hi, it worked !
I turned on gfx.webrender.compositor.force-enabled to true and the video is play in HDR !
There is a small but, because the white are burned. The video is not grey anymore, the colors display well but in the white grade, it's washed out unlike in edge for the test. But it's a step forward :-)

Thanks for testing, that confirms the cause. Feel free to keep the pref on if video works fine for you, but if you see video freezing after switching windows, that's the problem the block is there to avoid. We've asked Sotaro whether the block is still needed with current drivers.

The bright areas losing detail is a separate issue. Your monitor reports a peak of 436 nits, and this video is probably mastered much brighter than that. Edge most likely compresses the highlights to fit the display, while Firefox currently sends the PQ signal through unchanged, so anything brighter than the display can show gets clipped. That's bug 2055652.

See Also: → 2055652

Your setup can also help us find out whether the block is still needed. Firefox's compositor has been reworked since the block was added, so the freeze it was added for may be gone. If you have time, with gfx.webrender.compositor.force-enabled still set to true:

  1. Start a video playing in Firefox (YouTube is fine).
  2. Switch to a fullscreen game that uses DirectX 11 and puts a heavy load on the GPU, and play for at least 30 seconds.
  3. Switch back to Firefox. Does the video keep playing, or is the picture frozen while the audio continues?

Please try it a few times. In the original report the freeze only happened with a demanding DirectX 11 game, after more than about 10 seconds away from Firefox. Games using Vulkan didn't trigger it.

Flags: needinfo?(laurent.h)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: