212017 - Unable to change a bug if it has a flag requested that is no longer requestable

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Dave Miller [:justdave]]

I tried to add myself to the CC on bug 192425, which had "blocking 1.4" set to
"?".  blocking 1.4 has since been disabled (and has the "requestable" flag
cleared as well).  It would not let me add myself to the CC because it
complained that "?" wasn't a legal setting for that flag.

Bugzilla has suffered an internal error. Please save this page and send it to
[e-mail] with details of what you were doing at the time this message
appeared.

URL: http://bugzilla.mozilla.org/process_bug.cgi

   The flag status ? is invalid.

Variables:
    status: ?
    id: 42101

Comment 1

[Dave Miller [:justdave]]

Asa/Ian: the reason you guys got copied:

The following link displays the list of bugs that users can no longer make
changes to because of this bug.

http://bugzilla.mozilla.org/request.cgi?action=queue&type=blocking1.4&group=type

Someone needs to either clear/grant/deny the "blocking 1.4" flag on all of those
bugs before anyone will be able to make changes to them again.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

I've added back "requestability" to that flag on b.m.o so changes won't fail
anymore.

Comment 3

[Frédéric Buclin]

-> I take this one! :)

Comment 4

[Frédéric Buclin]

Attachment: Allows "?" if already set

If a flag is requested before this flag type becomes unrequestable, "?" still
has to be displayed! The 2.18 branch and the trunk both actually display the
requester, I think also the requestee if any (didn't check this point), but the
"?" flag is not visible (i.e. is unavailable)! This doesn't make sense!! Even
worse, the activity log shows that "?" is still kept in the DB (it really is),
but if the user clicks "submit", this flag will definitively be deleted.

Comment 5

[Frédéric Buclin]

Comment on attachment 163217 [details] [diff] [review]
Allows "?" if already set

myk, justdave, I think this should be included in 2.18 as well as in the trunk.

Comment 6

[Frédéric Buclin]

This problem seems to exist since 2003-04-24 22:41 and the check-in of bug
179510 about the error message and since 2002-11-09 05:57 and the check-in of
bug 179205 about the UI.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 163217 [details] [diff] [review]
Allows "?" if already set

Thanks, this is a great fix.

>+        # If the flag was requested before it became unrequestable, left it as is.

Nit: "left it as is" should be "leave it as is" for consistency in grammatical
tense between this comment and the others in this file.

r=myk

Comment 8

[Frédéric Buclin]

As said in comment 5, this patch should also go into the 2.18 branch, IMHO.
Requesting approval...

Comment 9

[Frédéric Buclin]

Attachment: Allows "?" if already set, v1.1

Nit corrected: "left it as is" -> "leave it as is".

Comment 10

[Myk Melez [:myk] [@mykmelez]]

This is a good, low-risk correctness fix that it makes sense to get into our
impending releases.

Comment 11

[Vlad Dascalu]

Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.18.2.3; previous revision: 1.18.2.2
done
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.12.2.1; previous revision: 1.12
done

Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.22; previous revision: 1.21
done
Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.14; previous revision: 1.13
done

Comment 12

[Frédéric Buclin]

*** Bug 251738 has been marked as a duplicate of this bug. ***