Closed Bug 213877 Opened 21 years ago Closed 21 years ago

update contentAreaUtils.js callers to pass type and extension to mimeservice


(Core Graveyard :: File Handling, defect)

Not set


(Not tracked)



(Reporter: Biesinger, Assigned: Biesinger)




(1 file)

from bug 147679 comment 41
>Index: xpfe/communicator/resources/content/contentAreaUtils.js

The callers in this file could easily be updated to make use of our brand new
better stuff.  Please file a followup bug on that (just file it on me; cc me on
the other bugs I asked you to file).

(this would be for  function getMIMEInfoForExtension(aExtension) and function
getMIMEInfoForType(aMIMEType), like basically merging them I guess)
Depends on: 160454
Blocks: 129979
OS: Linux → All
Hardware: PC → All
No longer blocks: 213516
*** Bug 220879 has been marked as a duplicate of this bug. ***
*** Bug 221930 has been marked as a duplicate of this bug. ***
Is Bug 221930 really dupe of this bug?
I don't see any info, that it would be similar problem.

If in any way this bug causes Bug 221930, then my question is, if this will be
fixed in the final release of Mozilla v1.5? It is very disturbing to always
remove the .htm extension from "filename.html.htm".

Any info?
This won't be fixed until bug 160454 is fixed.  Which will not be in 1.5 and may
not be in 1.6 unless someone steps up to fix it.  And yes, bug 221930 is
precisely caused by this bug.
Bad to hear, it will be not fixed in v1.5, and may not in even 1.6.
It is very disturbing to always correct the filenames at Save As dialog :-(

My +1 vote to fix that bug & dependencies.
Blocks: 204267
Comment #4, Boris Zbarsky:
Hmmm, I just remember that the .html.htm problem was not happening in earlier
versions of Mozilla, e.g. 1.4 or so.
It was always offered .html and not .html.htm extension.
This should be still a bug, that was "implemented" since those versions...
Some other code changed; this is the one caller of the other code that has not
yet been updated to deal.

For what it's worth, you could get extension messups with this code in 1.4 as
well; there are plenty of bugs on that.
Wouldn't be possible to "fix back" at least the .html.htm extension bug in the
1.5 Final release?
It is disturbing so much, that questions if the upgrade worths at all, since by
the upgrade makes you additional work (to always delete the added .htm extension
at Save as).
No, that's not possible, since it would reintroduce numerous other bugs that
were fixed by that change.
*** Bug 225488 has been marked as a duplicate of this bug. ***
taking, I have a patch that doesn't depend on bug 160454
Assignee: bz-vacation → cbiesinger
No longer depends on: 160454
Attachment #136163 - Flags: superreview?(bz-vacation)
Attachment #136163 - Flags: review?(
Target Milestone: --- → mozilla1.7alpha
Comment on attachment 136163 [details] [diff] [review]

I guess this is ok, but it would be nice if the logic matched DoContent (eg
handling of POST, GET, content-disposition, etc). Maybe we should have an
interface method somewhere for that... :(

anyway, sr=bzbarsky; I'd try to get this in for 1.6...
Attachment #136163 - Flags: superreview?(bz-vacation) → superreview+
bz: yeah, that would be nice; but the usage of channels will go away sometime
anyway (per the "don't use HEAD" bug)...

and in case we reconsider that, we should have an interface method, imo.
Attachment #136163 - Flags: review?( → review+
Comment on attachment 136163 [details] [diff] [review]

this fixes the most common issue with "wrong extension when saving file", it
would be nice to get this into 1.6beta
Attachment #136163 - Flags: approval1.6b?
Comment on attachment 136163 [details] [diff] [review]

a=asa (on behalf of drivers) for checkin to 1.6beta
Attachment #136163 - Flags: approval1.6b? → approval1.6b+
Checking in resources/content/contentAreaUtils.js;
/cvsroot/mozilla/xpfe/communicator/resources/content/contentAreaUtils.js,v  <--
new revision: 1.96; previous revision: 1.95
Closed: 21 years ago
Resolution: --- → FIXED
Should probably retest the bugs this blocked..
yeah, I asked for retest of bug 204267 (mac), and supposedly one of bug 129979
and bug 163254 affects exthandler rather than contentAreaUtils, I picked the
latter for that because it has "save link target as" in the summary (and marked
it fixed)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.