Closed Bug 214527 Opened 21 years ago Closed 21 years ago

Add Bookmark Dialog UI

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: bugs, Assigned: p_ch)

References

Details

Add Bookmark dialog is tiny, jumps in size as it appears etc. Evaluate and specify UI, making code changes as required.
Bug 178514 asks for a tree view. Bug 181033 asks for a new folder button.
Depends on: 178514, 181033
Flags: blocking0.8?
I already have a UI spec in mind for this. Here's an excerpt from an email I sent out about 2 years ago. It's slightly out of date. ============================ The current "Add Bookmark" dialog has a few problems, including: - size persistence problems due to resizable tree widget - 'Use Default' button that is visually meaningless in most cases - bulky appearance with lots of UI elements (tree and associated buttons add clutter & complexity) Here's my proposed redesign: +-------------------------------------------------+-+ | Add Bookmark |X| +-------------------------------------------------+-+ | | | _Name: [ CNN.com ] | | _Location: [ http://www.cnn.com/ ] | | | | _Create in: [ My Bookmarks :^] | | | | | | ( Cancel ) (( Add Bookmark )) | | | +---------------------------------------------------+ +-------------------------------+ [ | (1) My Bookmarks (default) | :^] | ------------------------- | | (2) School | | Work Resources | | Personal Toolbar Folder | | News & Current Affairs | | ------------------------- | | (3) New... | +-------------------------------+ (1) - Root Bookmarks Folder icon (2) - Standard Bookmarks Folder icon (3) - Folder Icon with "+" or twinkle overlayed. Selecting "New..." invokes dialog: +----------------------------------------+-+ | Create New Folder |X| +----------------------------------------+-+ | | | Enter a name for the new folder: | | | | +------------------------------------+ | | | New Folder | | | +------------------------------------+ | | | | ( Cancel ) (( Create Folder )) | | | +------------------------------------------+ When the Create Folder button is selected, the user is returned to the above dialog, with the Create in menulist set to show the newly created folder as create-in. How it Solves Problems: - Menu list is fixed size, so sizing problems are eliminated. - Use Default button is removed in favour of a separated, bolded (default) menu item called "My Bookmarks" or similar, which indicates the default storage location. This item is preselected and easily identifiable. - Clutter in dialog reduced using simpler, smaller widgets. New Folder button removed in favour of a menu option. Use Default button replaced by menu option. ============================
Status: NEW → ASSIGNED
I'd prefer a tree view. Bug 207706 has made a nice proposal, including screenshots.
Not a developer, but i also prefer the solution in bug 207706 cleaner and easier to understand (better overview). Cleaner than having 3 dialogs.
I agree with the criticisms of the current dialog - it looks unfinished - but could I add a suggestion that Cmd-D simply adds the bookmark to the current target folder without interaction, and a parallel interface (e.g. Cmd-Opt-D) added that brings up the dialog, etc.
taking
Assignee: bugs → p_ch
Status: ASSIGNED → NEW
Came here after seeing the recent checkin on Bonsai. You may already be aware of this, but every time you click the arrow to show/hide the tree view, the dialog grows a bit wider.
Ben Fowler: the inconveniance of that approach is that the user has to remember which is the target folder. The new dialog should be really quicker to appear, Ctrl-D + Enter is just one additional keystroke. I landed the first part of the new dialog, it features a dropdown menu that lists the most recently used folders and an expandable tree for the folders not listed. I still have to hook up the 'new folder' functionality and to pretty up the dialog a bit.
Jon: I noticed that, there are also other little pbs, I'll file them after I work again on it this evening.
Any chance of getting a description field in a disclosure triangle? See http://surfmind.com/cgi-bin/wiki.pl?BookMarks/FireBirdFileDialog Bravo on the recent folders list.
Jon: that seems to be bug 90276. Andy: I noted your suggestion, we will also rewrite the bookmark property dialog sometimes soon.
I am using the 20031209 build and my first impression for the new "add bookmark" is that it is confusing. 1. There is a dropdown named "Create in:", I thought I was going to see all my bookmarks folders there, but I only saw 4 of them. Is this a bug? 2. There is a button with an arrow. Pressing it revealed a tree of all my bookmarks. How about naming the button, explaining what it does? "expand", "show folders" or something else. It should be clear what a button does, you shouldnt click on it to find out. 3. "Bookmark all tabs in a folder", how about "Bookmark all current tabs open in a folder"? 4. No "New folder..." button. Sorry if I am making these comments on a unfinished dialog, still this is much better than the old one.
marking fixed, even if there are still some issues, some not reported but I am aware of. New issues should be filed in new bugs.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
I filed three reports here: Bug 228582 Bug 228586 Bug 228585 Perhaps we should make a meta to keep track of all of these modifications that are being made to the "Add Bookmark" dialog?
*** Bug 230411 has been marked as a duplicate of this bug. ***
*** Bug 231012 has been marked as a duplicate of this bug. ***
I really have searched through the bugs but didn't find one that would adress that I am not able to sort my bookmarks in the actual bookmarks (not the manager) according to date, name, last changed, etc (which is a real bummer for me since I got hundreds of links in different categories and the default is alphabetic sorting). Is this bug adressing it or could anyone point me out to it?
verified fixed 2004-01-31 trunk build on W2K
Status: RESOLVED → VERIFIED
Flags: blocking0.8?
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.