214802 - advanced address book search: search street/city searches only work address

Status: ASSIGNED

(MailNews Core :: Address Book, defect)

Description

[David Harper-Jones]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

If you search the address book based on the "Street" or "City" containing
particular text, a card will only be found if the work address contains that
text; if only the home address contains the text, the card is not found. When
you choose the field you want from the drop-down list, unlike "Work phone" and
"Home phone", "Street" and "City" are presented as being generic, not
specifically work or home.

Related issue (refer to bugs #s 134435, 136309, 184483): the search would be
more flexible if you could search on work address and home address separately.
Really, I'd like to see the ability to search on _every_ field in the address
book: Zip code, Notes, Custom 1, 2, 3, 4, Web address, etc.

Subsidiary issue: the field should have the same name in both the card and the
search dialog: either "Address" in both places (preferably), or "Street" in both.

Reproducible: Always

Steps to Reproduce:
1. make two cards, on with "Broadway" in the home address and "New York" inthe
home city, one with "Broadway"/"New York" in the work address/city.
2. search for (Street contains "Broadway") or (City contains "New York").
3.

Actual Results:  
Only the card with the text in the work address is found.

Expected Results:  
Both cards should be found.

Comment 1

[Matthias Versen [:Matti]]

*** Bug 214803 has been marked as a duplicate of this bug. ***

Comment 2

[Matthias Versen [:Matti]]

*** Bug 214804 has been marked as a duplicate of this bug. ***

Comment 3

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 4

[Mark Banner (:standard8)]

Confirming with:
Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.8b4) Gecko/20050913 SeaMonkey/1.0a

Comment 5

[lijuan wang]

verified with:

Thunderbird version 2 beta 2 (20070326)
Trunk :version 3 alpha 1 (20070403)

Test on  Solaris Nevada snv_61 vemillion62_dev

Comment 6

[Andrew Fisher]

This bug is still present in Thunderbird version 2.0.0.18 (20081105) on Windows and has annoyed at least one user enough to make him register for a Bugzilla account just to keep this issue live.

Comment 8

[:Hb]

Searching the second street field for both addresses is wanted too.

Comment 9

[Thomas D. (:thomas8)]

Similar bug 184483 is about adding missing fields from the contact's card to the dropdown list in Advanced Address Book Search dialogue.

This is about a technical fault / ambiguity / inconsistency in the UI when resolving "street" or "city" fields found in the dialogue's fields dropdown. I'm surprised we have "Address" with two fields each on the card, but "street" or "city" here which looks inconsistent and error-prone, as indicated in comment 8.

Comment 10

[Thomas D. (:thomas8)]

per comment 9

Comment 11

[Ant]

I noticed this two decades old bug also shows up in my 64-bit Thunderbird v102.11 as well. :( There's a new bug report for it in https://bugzilla.mozilla.org/show_bug.cgi?id=1832390.

Comment 12

[Nuno Silva [:njsg]]

AB search code in TB is in a separate file but I think it still uses the same logic to build the search string.

It seems at least now (tested in 2.53.17b1pre) I can build a search string that has an (or...) for multiple attributes even inside an (and...) search, but I'd like to understand this better, to make sure it doesn't break anything.

Comment 13

[Nuno Silva [:njsg]]

Attachment: 214802-ab-search-home-253.patch

An attempt at adding the private/home fields in the search dialog code. (Also adds the second address lines.)

This seems to work here, but is this a good way to handle it, and is it enough? Is the restriction about mixing "and" and "or" completely gone or is there some situation where this might not work?

Does anything need to be done for LDAP? (LDAP searches still work with this, so at least it doesn't break.)