217942 - No visible hotkeys for get all mail and no menu items for "Get mail" [get new messages]

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Peter Richter]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030830 Firebird/0.6.1+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.5b) Gecko/20030830 Firebird/0.6.1+

I coudnt find any different way to download mail for the currently selected
account then clicking the "Get mail" button in the main tool bar or waiting for
a scheduled download. There should be an hotkey like F5 or something. To have
have menu entries for downloading mails for the *currently selected* account and
for downloading messages from *all* accounts (of the currently selected type
[mail/news]?) would be another improvment of convenience.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Stephen Walker]

*** Bug 232330 has been marked as a duplicate of this bug. ***

Comment 2

[Ray Birks]

Good news and bad news: [CTRL]+t is the already functioning (but admittedly
hidden in ThunderBird) keyboard shortcut to Get Mail. I agree that it should be
indicated somewhere in the dropdown menus, but alas, it isn't.

I would suggest adjusting the bug a bit. First, this circumstance is true on all
platforms and all OSes, so I recommend changing those.

Depending on the designers' plan for ThunderBird, this bug may instead be an
'enhancement' request (see Severity). That's how I would mark it.

Perhaps the summary could instead be: Add Get Mail [CTRL]+t to menu bar.

Finally, I would also suggest creating a separate bug for the other menu
entry/entries to get mail for specific accounts.

Comment 3

[Manish Jethani]

I'm using:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040410

That's Mozilla 1.7b. It has both Get New Messages (Ctrl + T) and Get All New
Messages (Ctrl + Shift + T) in the File menu. Is this going to get into Firefox?

Comment 4

[Grey Nicholson (they/them)]

See also bug 237542 comment 1 and bug 237542 comment 4; that is a Firefox bug
but the same principle applies.

Comment 5

[Anbo Motohiko]

Since Bug 249741 is fixed, we have 'Get New Messages for' in File menu. It
contains 'Get All New Messages' menuitem and menuitems corresponded to accounts.

Adding accesskey info. to selected account is bad thing, because users will
misunderstand 'ctrl+t' is only for *that* account.

I think that new menuitem labeled 'Get New Messages for current account' is better.

Comment 6

[Wayne Mery (:wsmwk)]

"Get new messages" is the menu item - "get mail", while descriptive, is not
strictly accurate

Comment 7

[Mike Cowperthwaite]

(In reply to comment #6)
> "Get new messages" is the menu item - "get mail", while descriptive, is not
> strictly accurate

Actually, it *is* accurate because, in the menu, both Get All New and Get New For <Account> only work for mail.  There is no capacity in the menu to Get All New Items for a news account, a newsgroup, an RSS account, or an RSS feed; you need to use the hotkey or default toolbutton action.  Which is the real problem, IMO; see bug 324221.

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

May be UI description issue, not sure if this is a bug at all, CC'ing Bryan to get some perspective.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Under the File menu:
 - add "Get New Messages" (the strings for it already existed)
 - Get New Messages for >:
   * change to "All Accounts"
   * add the hotkey for it

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: sceenshot with the patch applied

Comment 11

[Karsten Düsterloh]

Comment on attachment 316174 [details] [diff] [review]
proposed fix

>+<!ENTITY getAllNewMsgAllAccountsCmd.label "All Accounts">
>+<!ENTITY getAllNewMsgAllAccountsCmd.key "A">

Any good reason not to use the entity names already in use in SeaMonkey for the very same purpose?
(See attachment 145552 [details] [diff] [review].)

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

No, that was a slight oversight. 
On the plus side, I notice the key has been doubling as accesskey. I wonder how may locales that's broken in.

Comment 13

[Phil Ringnalda (:philor)]

Comment on attachment 316184 [details] [diff] [review]
proposed fix, v2

I'm tempted to say this product needs a ui-r flag. The code is impeccable, I'd happily review it again, but the UI feels off, having "Get New Messages [Only For The Account That Happens To Be Selected]" so primary, like it's optimizing for some use pattern I've never tried, where checking for messages is a rare and expensive task.

Comment 14

[Bryan Clark (DevTools PM) [:clarkbw]]

I'm not sure if this is what phil was talking about but I think we should be optimizing for the reverse of this patch.  Having the accelerator available allows what was asked for, but I want people to see Get New Messages as the default and sync everything item.

"Get New Messages" == Get Messages All Accounts
"Get New Messages For" -> Current Account??
                          [ list of accounts ]

I'm not sure about "Current Account", if anyone has suggestions for better wording but I'd like to refer to the current selected account.

Comment 15

[Magnus Melin [:mkmelin]]

I only ever use the "All accounts" options, since I have more than a few accounts that I want to manually check when I have time (a few news servers, low-low priority feeds, mail test accounts etc.) But then again, maybe none of the options need to be very optimized; new patch and suggestion coming up.

Comment 16

[Magnus Melin [:mkmelin]]

Attachment: screenshot with proposed fix, v3/v4

Comment 17

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v3

This also includes the 2 line fix to bug 431247 (by setting command=) for the relevant menu entries.

Comment 18

[walter sheets]

Your patch v3 works great for me on linux.  Can it be committed soon?

Comment 19

[walter sheets]

One problem:  Ctl-Shift-T works perfectly but the button for Get Mail/Get
All New Messages is grayed-out and therefore does nothing.  Can you get
it working again?

Comment 20

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v4

Good catch, the button wasn't working in the 3pane at first, and not in the standalone. Needed to add back (and call) getMsgToolbarMenu_init which bug 413781 removed.

Comment 21

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 321982 [details] [diff] [review]
proposed fix, v4

I'm assuming nothing has changed since the v3 screenshot.  Looks fine here.

Comment 22

[walter sheets]

(In reply to comment #20)
> Created an attachment (id=321982) [details]
> proposed fix, v4

This works perfectly for me, thanks!

Comment 23

[Phil Ringnalda (:philor)]

Comment on attachment 321982 [details] [diff] [review]
proposed fix, v4

Looks good, works fine, let's do it.

Comment 24

[Magnus Melin [:mkmelin]]

Checking in mail/base/content/mailWindowOverlay.xul;
/cvsroot/mozilla/mail/base/content/mailWindowOverlay.xul,v  <--  mailWindowOverlay.xul
new revision: 1.243; previous revision: 1.242
done
Checking in mail/locales/en-US/chrome/messenger/messenger.dtd;
/cvsroot/mozilla/mail/locales/en-US/chrome/messenger/messenger.dtd,v  <--  messenger.dtd
new revision: 1.76; previous revision: 1.75
done

->FIXED