431247 - "Get All New Messages" was broken (same action as "Get Mail" on selected account/folder)

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[WADA:World Anti-bad-Duping Agency]

"Get All New Messages" in drop down menu of "Get Mail" won't check all accounts.
Same action as "Get Msgs" on selected account/folder was executed.
Checked with next trunk builds on MS Win-XP SP2.
> Name=Thunderbird Version=3.0a1pre BuildID=2008042403
> Name=Thunderbird Version=3.0a1pre BuildID=2008042703

Note-1: Selection of an account in drop down menu works as expected.
Note-2: "Get Mail" works as expected on selected account/folder(Bug 428620 fixed)

Comment 1

[Joe Sabash [:JoeS1]]

Yes, I'm seeing this too, and I'm pretty sure it was there even before the fix for Bug 428620 so it's not a result of that fix.
 

Comment 2

[Magnus Melin [:mkmelin]]

This is a regression from bug 413781.
The "All accounts" doesn't pass a folder to MsgGetMessagesForAccount (duh). It used to have a command="cmd_getMsgsForAuthAccounts", still needs to. 

This is why "Get all new...." results in
Warning: reference to undefined property event.target._folder
Source File: chrome://messenger/content/messenger.xul
Line: 1

It was accidentally working before bug 428620.

I'll take care of this in bug 217942...

Comment 3

[Magnus Melin [:mkmelin]]

Bug 217942 landed - attachment 321982 [details] [diff] [review].

->FIXED

Comment 4

[WADA:World Anti-bad-Duping Agency]

"Get All New Messages" worked again as before with following build.
> Version=3.0a2pre, BuildID=2008060203 on MS Win-XP SP2.
VERIFIED.