220385 - Multiple close all tabs dialog pops-up on 'Exit Mozilla'

Status: RESOLVED WORKSFORME

(SeaMonkey :: General, defect)

Description

[bvr]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20030925
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6a) Gecko/20030925

When i use Exit from the File menu in Navigator it asks me if I want to 'close
all tabs' for every window opened with multiple tabs.

Reproducible: Always

Steps to Reproduce:
1. Open Navigator
2. Open a new tab
3. Repeat steps 1 and 2 (optional)
4. Go to File menu and choose Exit
Actual Results:  
Dialog popup for each time step 1 and 2 were repeated: "Confirm close -- This
Navigator window has 2 tabs open. Do you want to close it and all its tabs?"

Expected Results:  
I think a few seperate issues;

I expected mozilla to:
- Not warn about multiple tabs when there are less then two documents loaded.
- Do not show this warning on every window when using the 'Exit' function.


When have multiple windows open, and the user uses File|Exit a different warning
dialog could be used: "Confirm close -- Mozilla has # windows open. Do you want
to close it and all its windows?"


--
I'll choose severity 'minor' instead of 'cosmetic' because I sometimes
mistakenly use Exit and close to many windows ;)

Comment 1

[Charles Fenwick]

*** Bug 221663 has been marked as a duplicate of this bug. ***

Comment 2

[Andrew W]

For close message: "Mozilla has X tabs open in Y windows ..."?

Administrative:

Should this be changed to platform All, OS All since it seems to manifest on
multiple platforms?

OK to change title to "Multiple 'close all tabs' dialog pops-up on 'Exit
Mozilla'"?  Duplicate 221663 was filed because I could find nothing with 'close
all tabs' in title.

Comment 3

[bvr]

I would like to stress again that IMO this particular dialog shouldn't popup at
all when using 'Exit'. And that the other dialog I proposed should only popup
when there are multiple Mozilla windows 'in use', ie. are not blank navigator
windows.

Comment 4

[Olivier Vit (just a reporter)]

Agreed with comment #3
There has never been any warning when using ctrl-q to quit Mozilla
When you request to quit an application, it means that you want to quit, fast,
not to manage multiple alter boxes asking if you really want to quit...

Comment 5

[Stefan Borggraefe]

*** Bug 241152 has been marked as a duplicate of this bug. ***

Comment 6

[Ariel Burone]

This bug is similar to bug #254401 ant #250983 (but with a diferent point of view)

Comment 7

[Tobias Sager]

(In reply to comment #4)
> There has never been any warning when using ctrl-q to quit Mozilla
> When you request to quit an application, it means that you want to quit, fast,
> not to manage multiple alter boxes asking if you really want to quit...

That actually depends very much. 
I definitely vote for display the close dialog but provide an option to
disable this behaviour (as with the dialog when pressing Alt-F4 (Windows)).

Comment 8

[Tom Hessman]

(In reply to comment #7)
> I definitely vote for display the close dialog but provide an option to
> disable this behaviour (as with the dialog when pressing Alt-F4 (Windows)).

I agree.  There should be a prompt for those who didn't mean to close
everything, but it should be optional for those who don't want it.  Note that
Seamonkey already has the option to disable those prompts, so why should the
feature be removed altogether?

(In reply to comment #6)
> This bug is similar to bug #254401 ant #250983 (but with a diferent point of view)

To be clear, both of those bugs are for Firefox, not for Browser.  They are for
optional (but on by default) features that exist in Seamonkey, but that don't
work for Firefox, but that should because they help prevent data loss.

Comment 9

[Marc Bejarano]

this still applies to firefox and is pretty annoying.  when the auto-update system finishes downloading a new version and asks you if you want to restart firefox, now, you've presumably already agreed to close all those windows with all thost tabs.  having to confirm for every tabbed window is inelegant.

Comment 10

[Lloyd Wood]

It's still annoying with Firefox 1.5.0.2.

Not just for the File/Exit thing (I want to quit the application! I've explicitly said so! Don't ask me about individual windows one by one! Ask me about the application as a whole!), but when you have Windows XP grouping similar taskbar buttons in Properties, so that the right-click on the Firefox tab in the taskbar gives you a 'close group' option. If you select that and you have 'close all tabs' tab protection on, woe is you. If you have individual Mozilla windows minimized, woe is you.

The only good reason for the 'close all tabs' alert is to protect you from clicking the wrong 'close' X box at top right of the window, rather than to the right of the tab row. That is the only reason for this dialog to exist -- it is protecting you from a UI design screwup in the tabbar, where the two close buttons are close together and use the same gesture. The dialog protects you from closing one window, when you try to close one window. Not when you try to close multiple windows.

The way that this dialog has been implemented leads to multiple knock-on UI screwups, with File/Exit, 'Close group', and elsewhere. File/Exit and Close group can have their own single 'are you sure you want to quit the application and close all open windows?' dialog if there is more than one window open, with its own preference to disable it.

At least when Firefox crsahes you only have one dialog to contend with -- not one dialog per window.

Comment 11

[Michael Wu [:mwu]]

Fixed for Firefox on trunk by bug 383760. Making this bug for Seamonkey.

Comment 12

[Philip Chee]

WFM Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101113 SeaMonkey/2.1b2pre