224138 - Can't send S/MIME encrypted messages

Status: RESOLVED FIXED

(MailNews Core :: Security, defect)

Description

[Christian Eyrich]

I'm now able to generate encrypted messages and immediately run in a regression
from bug 163783.

S/MIME encrypted messages can't be sent because the messages last line doesn't
end with and CRLF. Before the fix of bug 163783 the send code added an
additional CRLF to the end of the message so this flaw didn't strike someone.

I didn't find the place where to add the CRLF, so someone else has to fix this.
The fix to this is _not_ to back out the other patch because each line of the
body itself has to be terminated by CRLF.

Comment 1

[Christian Eyrich]

*** Bug 224238 has been marked as a duplicate of this bug. ***

Comment 2

[Christian Eyrich]

*** Bug 224402 has been marked as a duplicate of this bug. ***

Comment 3

[Christian Eyrich]

1.6a is already out, I doubt anyone can stop it now.

Comment 4

[Kai Engert [:KaiE:]]

I propose to fix this bug, by making the logic in bug 163783 more intelligent.
See my comments there.

Comment 5

[Christian Eyrich]

Attachment: proposed patch

I think I finally managed to find an appropriate place to add the missing CRLF.
This code makes S/MIME encrypted messages work again.

Comment 6

[Christian Eyrich]

Comment on attachment 135129 [details] [diff] [review]
proposed patch

Should make it unnecessary to back out patch of bug 163783.

Comment 7

[Andrew Perry]

I'm begging for this bug to be fixed .... please.  What is the process to get
the above-mentioned patch placed into the trunk builds?  (I know, I'm completely
ignorant of the process around here)  Just wanted to see if I could stress a bit
more how important S/MIME encryption capability is for many of us corporate users.
Thanks.

Comment 8

[Christian Eyrich]

It's easy to get it in, the patch just need to be reviewed - I'm waiting for Kai.

Comment 9

[Asa Dotzler [:asa]]

Chris or Scott, can you help drive this patch?

Comment 10

[Scott MacGregor]

Comment on attachment 135129 [details] [diff] [review]
proposed patch

Let's get this checked in today.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 135129 [details] [diff] [review]
proposed patch

a=asa (On behalf of drivers) for checkin to Mozilla 1.6 Beta.

Comment 12

[Scott MacGregor]

checked in

Comment 13

[Christian Eyrich]

Great, thanks!

Comment 14

[Larry Riffle]

*** Bug 224822 has been marked as a duplicate of this bug. ***