226511 - Speed up cookie deleting in the cookie manager by batching

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

Wehen deleting multiple cookies from the cookiemanager, for every deletion the
entire list is loaded (and sorted) again. This is obviously very slow when
deleting lots of cookies.
Postponing the loading of the list will fix this. patch coming.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: Postpone loading until after all deletions

Comment 2

[Ludovic Hirlimann [:Usul]]

Isn't this bug a dup of 210465 ?

Comment 3

[Oliver Klee]

Changing summary from "Deleting lots of cookie from the cookie mananager is
slow" to "Speed up cookie deleting in the cookie manager by batching".

Comment 4

[Oliver Klee]

*** Bug 210465 has been marked as a duplicate of this bug. ***

Comment 5

[Nicholas Allen]

If it's the actual sort that is slow, that should hopefully be improved by bug
224128.  But batching deletes before redisplaying is probably a good idea.

Comment 6

[[e-mail]]

i like this patch... it's something i can incorporate into my
make-cookiemanager-not-suck patch as well :)

i don't think it's the sorting that's slow - it's just reloading the list, and
trying to do everything n times instead of once, that inherently makes it
irritating.

fwiw:
+  for (var c = deletedCookies.length - 1; c >= 0; c--) {

you can make this just:

   for (var c = deletedCookies.length; c--; ) {

Comment 7

[[e-mail]]

Attachment: Don't reload at all - we already delete the rows

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 136179 [details] [diff] [review]
Don't reload at all - we already delete the rows

Yeah, this will work too. Thanks Neil.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

*** Bug 226625 has been marked as a duplicate of this bug. ***

Comment 10

[chris hofmann]

think its too late for 1.6 on this.  a good one for 1.7

Comment 11

[Jo Hermans]

*** Bug 228541 has been marked as a duplicate of this bug. ***

Comment 12

[Malcolm Rowe]

*** Bug 228642 has been marked as a duplicate of this bug. ***

Comment 13

[benc]

mvl: Bug 228642 says this causes a full hang (not just slow) in 1.6 beta. Do you
think that is a dupe or a new problem?

Comment 14

[Michiel van Leeuwen (email: mvl+moz@)]

*** Bug 232152 has been marked as a duplicate of this bug. ***

Comment 15

[Darin Fisher]

Comment on attachment 136179 [details] [diff] [review]
Don't reload at all - we already delete the rows

sr=darin

Comment 16

[[e-mail]]

Fix checked in.

Comment 17

[Mike Connor [:mconnor]]

*** Bug 238342 has been marked as a duplicate of this bug. ***

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2004-07-25-09 on Windows XP.  This has been quite
zippy for a while now.