227224 - Filter news with 'Watch Thread' -- thread does not appear watched

Status: NEW

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Mike Cowperthwaite]

I have a filter defined to automatically mark a newsgroup thread as Watched if a 
message arrives in the thread from me.  (Yes, this is a hack compared to what I 
actually want: bug 227223.)  

It seems that the filter executes correctly, but the thread does not display as 
Watched in the front end, until I leave the group and then come back to it.  
(Compare to filtering with 'Ignore Thread' which apparently does suppress the 
thread's display right away.)

Comment 1

[Mike Cowperthwaite]

Possibly related to bug 123047.

Comment 2

[Mike Cowperthwaite]

Might also be related to bug 207285.

Comment 3

[Scott MacGregor]

I can reproduce this.

and like mike says, when I switch and come back, it looks ok.

probably a bug in nsNNTPNewsgroupList.cpp or the view code.  

my $1 is on the news code.

Comment 4

[Scott MacGregor]

yes, looks like the code in nsNNTPNewsgroupList is marking the thread as watched
or ignore is wrong.

patch coming in a patch for bug #19403

Comment 5

[Scott MacGregor]

I don't have a proper fix for this in bug #19403, it will have to be fixed
another way.

Comment 6

[David :Bienvenu]

Attachment: proposed fix

this makes it so when the view gets a hdr added, it checks if the thread is
watched, and if so, puts the watched flag in the view...what this doesn't fix
is that when you hit get new msgs, clearing the new flag also clears the watch
flag in the view...because it only uses the msg hdr flags, and ignores the
thread flags.

Comment 7

[Scott MacGregor]

over to david.  thanks david!

Comment 8

[David :Bienvenu]

sr=mscott, over AIM. This is partly fixed, except for when you do get new msgs
again...

Comment 9

[[e-mail]]

Attachment: Alternate approach

The idea here is that we also get the watched and ignored states from the
thread from which we already get the unread counts. I suppose a complete patch
should remove all the code that sets the watched ang ignored flags on the msg
hdr...

Comment 10

[Mike Cowperthwaite]

(In reply to comment #6)
> proposed fix
> 
> this makes it so when the view gets a hdr added, it checks if the thread is
> watched, and if so, puts the watched flag in the view...what this doesn't fix
> is that when you hit get new msgs, clearing the new flag also clears the watch
> flag in the view...because it only uses the msg hdr flags, and ignores the
> thread flags.

I don't quite follow what's being described as the exceptional case there.

What I *am* seeing, with the patch from 19403 in 1.8a-0420, is that the 
'watched' state is being shown on the original entry to the newsgroup, and 
remaining set after an explicit Get New Msgs; this is a big improvement already.
However, if a message arrives with the Get New Msgs that triggers the filter, 
then that thread is not shown as Watched until I re-enter the group.

Comment 11

[Mike Cowperthwaite]

I suspectk the side-effect to bug 19403's patch which (apparently) partially 
addressed this bug also addressed bug 207285 -- that problem has mysteriously 
stopped occurring, altho I haven't checked a variety of builds.

Comment 12

[Scott MacGregor]

the 2004/04/18 patch is checked into the aviary 1.0 branch.

Comment 13

[Wayne Mery (:wsmwk)]

(In reply to comment #10)
> However, if a message arrives with the [timed] Get New Msgs that triggers the filter, 
> then that thread is not shown as Watched until I re-enter the group.

It's even a little weirder than that now.  Messages gotten via timer seem to be gone...
 
--version 2.0.0.5 (20070716)
thread doesn't show *at all*, but the message count went up.
click another group, and click back, thread still not there
rebuild index, thread still not there
   
--version 3.0a1pre (2007082704)
same results.
and continuing with more tests...
explicit ctrl-T get new messages - the messages appear, but only the missing ones from *this* startup - prior test messages, the ones that got filtered on v2 that didn't show above, do not appear


final observation - happens with "TAG" action, so "watch thread" is not the only filter action affected and I would guess other actions are affected.

I did not try deleting the newsgroup files to see if some of the symptoms go away. And I did not make a second pass of tests.

Comment 14

[Serge Gautherie (:sgautherie)]

David, Neil,
Are you still working on this ?

Comment 15

[[e-mail]]

Comment on attachment 146578 [details] [diff] [review]
Alternate approach

This landed as part of bug 112833.

Comment 16

[David :Bienvenu]

Pretty sure Joshua is taking care of this in an other bug.

Comment 17

[Ludovic Hirlimann [:Usul]]

Joshua what's the status here ?