227695 - Incorrect serialization of font shorthand when it's set to a system font

Status: RESOLVED DUPLICATE of bug 475214

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

"font: icon" 

is serialized as 

  "font-family: icon; font-style: ; font-variant: ; font-weight: ; font-size: ;
   line-height: ; font-size-adjust: ; font-stretch: ;"

which is pretty bogus...

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: testcase

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It doesn't look like we ever serialize to the 'font' shorthand, at least from
the looks of nsCSSDeclaration::ToString.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Right.  And for cases when the "font" value is not a generic, that's fine -- it
produces valid CSS equivalent to the original shorthand.

However, due to the way we store generic-only values in the data struct (by
setting blank nsCSSValues for all the other sub-properties at
http://lxr.mozilla.org/seamonkey/source/content/html/style/src/nsCSSParser.cpp#5040)
this case actually breaks roundtripping quite badly...

The easiest solution is probably to start serializing to the font shorthand.  :(

Comment 4

[Boris Zbarsky [:bzbarsky]]

*** Bug 281388 has been marked as a duplicate of this bug. ***

Comment 5

[Felix Miata]

Is this distinguishable from bug 216456 ?

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Is this distinguishable from bug 216456 ?

Yes.  This bug is about serialization, that bug is about computed style.  They're not the same at all.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This was fixed by http://hg.mozilla.org/mozilla-central/rev/768c8c967b0d .