228165 - Add Bookmark dialog should be shown as a sheet on Mac OS X

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Kevin Gerich]

The Add Bookmark dialog is shown as non-modal on all platforms but would be most
appropriate as a document-modal sheet on Mac OS X. Safari and Camino also show
the  add bookmark dialog as a sheet. See above URL for the relevant section of
the Aqua HIG.

Comment 1

[Wayne Woods]

Agreed, it would be better. If someone does look into this, then hopefully they
could switch the "About" dialog window in the other direction (sheet  ->
modeless, see bug 222364) at the same time, as the curent way it is can be a pain :)

Comment 2

[Robert Curtis]

I further this request, plus tidying up the (what I think is) disclosure widget,
such as making it a widget with a triangle in it.

Comment 3

[Wayne Woods]

I'm pretty sure the latter is a theme issue with pinstripe. Other themes show
something on the button.

Comment 4

[Asaf Romano (gone)]

Attachment: patch

Comment 5

[Asaf Romano (gone)]

Attachment: patch

update to tip

Comment 6

[Asaf Romano (gone)]

Checking in browser//base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.382; previous revision: 1.381
done
Checking in browser//base/content/utilityOverlay.js;
/cvsroot/mozilla/browser/base/content/utilityOverlay.js,v  <--  utilityOverlay.js
new revision: 1.15; previous revision: 1.14
done
Checking in browser//components/bookmarks/content/bookmarks.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v  <-- 
bookmarks.js
new revision: 1.93; previous revision: 1.92
done
Checking in browser//components/sidebar/src/nsSidebar.js;
/cvsroot/mozilla/browser/components/sidebar/src/nsSidebar.js,v  <--  nsSidebar.js
new revision: 1.10; previous revision: 1.9
done

Comment 7

[Steffen Wilberg]

When opening the bookmarks manager, the js console shows:
Error: redeclaration of const ADD_BM_DIALOG_FEATURES
Source File: chrome://browser/content/utilityOverlay.js
Line: 10

Comment 8

[Asaf Romano (gone)]

(In reply to comment #7)
> When opening the bookmarks manager, the js console shows:
> Error: redeclaration of const ADD_BM_DIALOG_FEATURES
> Source File: chrome://browser/content/utilityOverlay.js
> Line: 10

see bug 287885 (awaiting review), that's actually a regresiion from the menus bug.

Comment 9

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change