Closed Bug 228165 Opened 18 years ago Closed 17 years ago

Add Bookmark dialog should be shown as a sheet on Mac OS X

Categories

(Firefox :: Bookmarks & History, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox1.5

People

(Reporter: kevin, Assigned: mano)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

The Add Bookmark dialog is shown as non-modal on all platforms but would be most
appropriate as a document-modal sheet on Mac OS X. Safari and Camino also show
the  add bookmark dialog as a sheet. See above URL for the relevant section of
the Aqua HIG.
Agreed, it would be better. If someone does look into this, then hopefully they
could switch the "About" dialog window in the other direction (sheet  ->
modeless, see bug 222364) at the same time, as the curent way it is can be a pain :)
I further this request, plus tidying up the (what I think is) disclosure widget,
such as making it a widget with a triangle in it.
I'm pretty sure the latter is a theme issue with pinstripe. Other themes show
something on the button.
Flags: blocking-aviary1.0mac?
Assignee: p_ch → bugs.mano
Target Milestone: --- → Firefox1.1
Blocks: 277000
Attached patch patch (obsolete) — Splinter Review
Attachment #174361 - Flags: review?(vladimir)
Attached patch patchSplinter Review
update to tip
Attachment #174361 - Attachment is obsolete: true
Attachment #174779 - Flags: review+
Checking in browser//base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.382; previous revision: 1.381
done
Checking in browser//base/content/utilityOverlay.js;
/cvsroot/mozilla/browser/base/content/utilityOverlay.js,v  <--  utilityOverlay.js
new revision: 1.15; previous revision: 1.14
done
Checking in browser//components/bookmarks/content/bookmarks.js;
/cvsroot/mozilla/browser/components/bookmarks/content/bookmarks.js,v  <-- 
bookmarks.js
new revision: 1.93; previous revision: 1.92
done
Checking in browser//components/sidebar/src/nsSidebar.js;
/cvsroot/mozilla/browser/components/sidebar/src/nsSidebar.js,v  <--  nsSidebar.js
new revision: 1.10; previous revision: 1.9
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
When opening the bookmarks manager, the js console shows:
Error: redeclaration of const ADD_BM_DIALOG_FEATURES
Source File: chrome://browser/content/utilityOverlay.js
Line: 10
(In reply to comment #7)
> When opening the bookmarks manager, the js console shows:
> Error: redeclaration of const ADD_BM_DIALOG_FEATURES
> Source File: chrome://browser/content/utilityOverlay.js
> Line: 10

see bug 287885 (awaiting review), that's actually a regresiion from the menus bug.
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.